Add first service method to initial ContainerRegistryClient #19468

annelo-msft · 2021-03-12T00:09:21Z

Adding the initial version of the ContainerRegistryClient, with single GetRepositories() method. In addition, adding the test resources and a project with a single test that exercises the GetRepositories() method.

This is the first PR addressing #18916, and
Fixes #19291

annelo-msft · 2021-03-12T00:19:47Z

...tainerregistry/Azure.Containers.ContainerRegistry/src/Temporary/BasicAuthenticationPolicy.cs

@@ -0,0 +1,55 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.


This will be removed before first preview is released, per: #19469

annelo-msft · 2021-03-12T00:20:33Z

sdk/containerregistry/Azure.Containers.ContainerRegistry/src/ContainerRegistryClient.cs

+        /// <summary>
+        /// <paramref name="endpoint"/>
+        /// </summary>
+        public ContainerRegistryClient(Uri endpoint, string username, string password) : this(endpoint, username, password,  new ContainerRegistryClientOptions())


These constructors will be changed to standard Track 2 constructors before first preview release, per: #19469

check-enforcer · 2021-03-12T00:38:02Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

annelo-msft · 2021-03-12T00:44:28Z

/check-enforcer evaluate

annelo-msft · 2021-03-12T00:47:26Z

sdk/containerregistry/Azure.Containers.ContainerRegistry/src/autorest.md

@@ -8,3 +8,11 @@ require:
    -  https://github.com/Azure/azure-rest-api-specs/tree/255757f41275e8ec474361690ea8886cae8a503b/specification/containerregistry/data-plane/readme.md
 model-namespace: false
 ```
+


We have work in progress to update to a swagger to generate much of the Track 2 library: Azure/azure-sdk#2478

mitchdenny · 2021-03-12T00:58:27Z

/azp run net - containerregistry - ci

azure-pipelines · 2021-03-12T00:58:39Z

Azure Pipelines successfully started running 1 pipeline(s).

eng/Packages.Data.props

.../Azure.Containers.ContainerRegistry/api/Azure.Containers.ContainerRegistry.netstandard2.0.cs

...tainerregistry/Azure.Containers.ContainerRegistry/src/Temporary/BasicAuthenticationPolicy.cs

sdk/containerregistry/test-resources-post.ps1

sdk/containerregistry/test-resources.json

annelo-msft · 2021-03-12T18:23:50Z

/azp run net - containerregistry - ci

annelo-msft · 2021-03-12T18:24:25Z

/azp run net - containerregistry - ci

azure-pipelines · 2021-03-12T18:50:02Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2021-03-12T18:50:11Z

Azure Pipelines successfully started running 1 pipeline(s).

annelo-msft added 4 commits March 9, 2021 17:59

make internal; add client; EOD check-in

c1549be

added test-resources.json and basic auth policy.

5f2fd3d

Moving in test project; does not currently build

2337e57

set up test resources

abcb591

annelo-msft changed the title ~~Acr initial client~~ Add first service method to initial ContainerRegistryClient Mar 12, 2021

annelo-msft commented Mar 12, 2021

View reviewed changes

update api file

7916c66

annelo-msft commented Mar 12, 2021

View reviewed changes

update sample

708b6e2

annelo-msft marked this pull request as ready for review March 12, 2021 00:50

annelo-msft requested review from chidozieononiwu, danieljurek, KrzysztofCwalina, mitchdenny, tg-msft, toddysm, weshaggard and yugangw-msft as code owners March 12, 2021 00:50

annelo-msft requested review from JoshLove-msft, heaths and christothes March 12, 2021 00:50

heaths approved these changes Mar 12, 2021

View reviewed changes

annelo-msft added 2 commits March 12, 2021 08:31

pr fb and env var test

a32a133

modification to env var test

f4afd56

annelo-msft mentioned this pull request Mar 12, 2021

Make ACR test-resources.json file robust to different clouds or domain suffixes #19486

Closed

annelo-msft added 2 commits March 12, 2021 09:01

modification to env var test

4a29b4c

updates to recordings to fix playback in CI

39c8933

remove package dependency on System.Linq.Async

d77f68b

annelo-msft merged commit 612fcc8 into Azure:master Mar 12, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add first service method to initial ContainerRegistryClient #19468

Add first service method to initial ContainerRegistryClient #19468

annelo-msft commented Mar 12, 2021 •

edited

Loading

annelo-msft Mar 12, 2021

annelo-msft Mar 12, 2021

check-enforcer bot commented Mar 12, 2021

annelo-msft commented Mar 12, 2021

annelo-msft Mar 12, 2021

mitchdenny commented Mar 12, 2021

azure-pipelines bot commented Mar 12, 2021

annelo-msft commented Mar 12, 2021

annelo-msft commented Mar 12, 2021

azure-pipelines bot commented Mar 12, 2021

azure-pipelines bot commented Mar 12, 2021

		@@ -0,0 +1,55 @@
		// Copyright (c) Microsoft Corporation. All rights reserved.

Add first service method to initial ContainerRegistryClient #19468

Add first service method to initial ContainerRegistryClient #19468

Conversation

annelo-msft commented Mar 12, 2021 • edited Loading

annelo-msft Mar 12, 2021

Choose a reason for hiding this comment

annelo-msft Mar 12, 2021

Choose a reason for hiding this comment

check-enforcer bot commented Mar 12, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

For track 1 management-plane SDKs

annelo-msft commented Mar 12, 2021

annelo-msft Mar 12, 2021

Choose a reason for hiding this comment

mitchdenny commented Mar 12, 2021

azure-pipelines bot commented Mar 12, 2021

annelo-msft commented Mar 12, 2021

annelo-msft commented Mar 12, 2021

azure-pipelines bot commented Mar 12, 2021

azure-pipelines bot commented Mar 12, 2021

annelo-msft commented Mar 12, 2021 •

edited

Loading