Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Communication - Phone Numbers] Deploy test resources failing in nightly runs #19886

Closed
v-jiaodi opened this issue Jan 18, 2022 · 2 comments · Fixed by Azure/azure-sdk-tools#2592
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Communication test-reliability Issue that causes tests to be unreliable

Comments

@v-jiaodi
Copy link
Member

Communication - Phone Numbers nightly test runs are failing with:

Stack trace:
Get-AzADServicePrincipal_List: /usr/share/az_7.1.0/Az.Resources/5.2.0/MSGraph.Autorest/custom/Get-AzADServicePrincipal.ps1:219
Line |
219 | Az.MSGraph.internal\Get-AzADServicePrincipal @PSBoundParameters
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| ClientSecretCredential authentication failed: AADSTS70011: The
| provided request must include a 'scope' input parameter. The
| provided value for the input parameter 'scope' is not valid.
| The scope MicrosoftGraphEndpointResourceId/.default is not
| valid. Trace ID: 9b1d2a32-268e-4893-af1a-0adbaa5b1000
| Correlation ID: 0c2cabdf-80bc-4749-8882-f018d54370ed
| Timestamp: 2022-01-17 21:41:57Z

For more details check here:

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 18, 2022
@v-xuto v-xuto added Client This issue points to a problem in the data-plane of the library. Communication test-reliability Issue that causes tests to be unreliable and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Jan 18, 2022
@benbp
Copy link
Member

benbp commented Jan 19, 2022

This issue seems related to the deployment script updates we made to support the new Az powershell versions which switched from using AAD graph to using the MS graph API.

ghost pushed a commit to Azure/azure-sdk-tools that referenced this issue Jan 21, 2022
Currently there are some problems with the `Az.Resources` cmdlet v5.2.0 related to fetching service principals via the
graph API in private azure clouds. This manifests either as an error like below:

```
ClientSecretCredential authentication failed: AADSTS70011:
The provided request must include a 'scope' input parameter.
```

Or, if the `-MicrosoftGraphEndpointResourceId` parameter is supplied to the `Add-AzEnvironment` call, then the API
request returns a 500:

```
{"odata.error":{"code":"Request_DataContractVersionMissing","message":
{"lang":"en","value":"The specified api-version is invalid. The value must exactly match a supported version."}}}
```

I'm pretty sure there is still some missing functionality as support for non-public clouds was only recently added and
the AAD->MSGraph breaking change in azure powershell has had related issues.

Regardless of all this, we don't need to be doing an API call to get the OID in CI environments, because we already have
that value available and can pass it in as a parameter. So even if the above problems were fixed, I would still want to
make this change to reduce our test script running time. This update happens to bypass the problematic
`Get-AzAdServicePrincipal` call and fix the issue at hand.

Fixes Azure/azure-sdk-for-js#19886
@benbp
Copy link
Member

benbp commented Jan 21, 2022

Above PR has restored functionality. Passing pipeline: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1319218&view=results

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Sep 22, 2022
Merge Microsoft.app 2022 06 01 preview to main (Azure#20787)

* Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01

* Updates readme

* Updates API version in new specs and examples

* Add app diag to 2022-05-01 (Azure#18678)

* Add container apps diagnostics

* Fix validation errors

* Move Microsoft.App diag APIs to 2022-05-01

* Fix validation errors

* Fix validation errors

* Fix validation errors 3

* Change operationIds

Co-authored-by: Michimune Kohno <mikono@microsoft.com>

* Fix definition for customhostnameesult (Azure#19014)

* fix

* update

* more fix

* Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (Azure#19048)

* Correct Probe enums (Azure#18839)

* fix probe enums

* Fix revision mode enum

* Fix patch example

* Fix the casing of enums in the latest api version

* Change the parameter names to unblock Terraform release (Azure#19005)

* contianerapps: fixing swagger inconsistencies in 2022-01-01-preview

* containerapps: fixing inconsistencies in the 2022-03-01 swagger

* containerapps: updating the examples for 2022-01-01-preview

* containerapps: updating the examples to account for the updated parameter names

* containerapps: fixing linting

* fix probe enums

* Fix revision mode enum

* Fix the policheck error

* Revert "containerapps: fixing linting"

This reverts commit 3c4872f4a43fbe1a285830461f48d8c0a5ffeee8.

* Revert "containerapps: updating the examples for 2022-01-01-preview"

This reverts commit 9b81fbd65652d558c0296d72a63ca1a7c4850e3c.

* Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview"

This reverts commit 553fc551b3239598157238ed6246085748421b87.

* Undo changes to 2022-01-01-preview

* Fix one issue

* fix remaining inconsistency

* fix authConfig and sourceControl names

Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>
Co-authored-by: Mike Vu <mikevu@microsoft.com>

* Change param names

* Fix examples

* Fix CI errors

Co-authored-by: Mike Vu <mikevu@microsoft.com>
Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>

* Fix description in all API versions (Azure#19313)

* Fix description for ManagedEnvironment.Internal property (Azure#19307)

* Fix descriptions in all api versions

* Add traffic info to revisions api (Azure#19054)

* Add traffic info to a revision api

* Add deprecated prop

* Prettier fixes

* 1pdate based on new proposal

* Rename

* Change names

* minor fix

* Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (Azure#19360)

* Add httpReadBufferSize to dapr config

* remove nullable

* Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add new resources for 2022-06-01-preview (Azure#19494)

* update

* update

* update

* fix

* update

* update

* update

* update

* fix

* update

* update

* Enable Dapr AI Connection string for Microsoft.App connected environment (Azure#19974)

* Enable Dapr AI Connection string for Microsoft.App connected environment

* Fix dapr ai connection string

* remove read

* remove read permission of dapr ai connection string and instrument key for managed environment

* fixes for comments

* update (Azure#20013)

* Fixdescriptions on microsoft.app 2022 06 01 preview (Azure#20133)

* Fix casing for detector properties

* Fix descriptions

* Fix descriptions and detectorProperties in 2022-06-01-preview

* Added `secretsStoreComponent` in 2022-06-01 spec (Azure#20044)

* Added `secretsStoreComponent` in 2022-06-01 spec

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

* Fixed typos and added example of name/key

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

* Add custom domain configuration for managed environment (Azure#20149)

Co-authored-by: Mengjun Qin <menqin@microsoft.com>

* Add additional Dapr options (2022-06-01-preview) (Azure#19886)

* Add additional Dapr options

* Update examples for 2022-06-01-preview

* force ci

* force ci

* force ci

* adding ip-restriction feat (Azure#19841)

* adding ip-restriction feat

* remove from stable, add to preview

* fix lintDiff error

* fix modelvalidation error

* fix formatting changes

* rename names, add note to all allow or all deny

* fix spell check error

* update name and examples

* rename `ipAddress` to `ipAddressRange`

* making small change to re-run build pipeline

* trigger GitHub actions

* resolve comments

Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>

* Remove Traffic Labels from revisions because they haven't been impelemented (Azure#20261)

* Revert "Add traffic info to revisions api (Azure#19054)"

This reverts commit 056cc51226bf2eef3d3a7e7bdca875a4a571026b.

* Remove traffic labels from revisions

* Add property for tcp apps (Azure#20193)

* Add property for tcp apps

* Add scale

* Fix

* Fix

* Add Init Containers to common definitions (Azure#19855)

* add init containers to common definitions

* move changes to 06-01 preview

* remove repeated container definition

* fix allof syntax

* fix anonymous container definition

* fix lintdiff errors

* fix container allof syntax

* add more init examples

* split baseContainer definition

* remove description

Co-authored-by: p-bouchon <pbouchon@microsoft.com>

* Update container app provisioningstate (Azure#20411)

* update

* update

* add property: maxInactiveRevisions (Azure#20334)

* add property: maxInactiveRevisions

* update

* update

* Add premium sku related properties for managed environment (Azure#19770)

* Add premium sku related properties for managed environment

* Move sku to base property

* Add workloadProfileType

* Examples for managed environment

* Add container app example

* Fix workloadProfiles

* Add custom word

* Fix WorkloadProfileType references

* prettier fixes

* Fix workload profile

* Fix typo

* remove readonly property for workload profile

* Add object type

* nit: Fix description location

* Fix XmsIdentifierValidation

* Remove spaces from enum values

* Remove unwanted change

* Add aka ms url

* Update examples for workload profile type

* Fix rebase issue

* Fix json

* Update description and move location

* Remove provisioning state for node pool

* sku capacity explanation

* Remove capacity attribute

* Remove capacity attribute from required

* Mark sku property as required

* Add x-ms-identifiers

* Rename mimum and maximum

* Rename skutype to skuName

* Make sku property as optional

* Make workload profile type as string

* fix go SDK automation config

Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>

* Fix source control status code in 2022-06-01-preview. (Azure#20429)

* Remove 20220501 because we will not support it in server side (Azure#20427)

* remove

* update

* Added support for user defined routing (Azure#20464)

* Added support for user defined routing

* Added examples

* fixed JSON syntax

* syntax fix

* fixed vnetenvironment syntax

* fixed camel case

* case fix

* enum syntax

* fixed comma cases ManagedEnvironmentOutBoundType

* fixing casing

* Some more APIs (Azure#20448)

* new APIs to 06-01

* test fix

* more fixes

* add last active time for revision (Azure#20658)

* Add custom domain for connected env (Azure#20731)

* add custom domain

* fhcekout

* billingMeters - GET endpoint (Azure#20485)

* Swagger documentation for /locations/{location}/billingMeters - GET endpoint

* Add example, fix validation errors

* Fix ARM validation errors, code review comments

* Fix response validation

* add proxy resource properties

* Response formatting

* add default error response

* ARM Review feedback + small naming change for a property

* Change GB to GiB

* Fix 2022-06-01-preview branch merge conflicts (Azure#20773)

* Reset

* more fixes

* More fixes

* another conflict fix

* Fix old preview version

* fix 2022-03-01

* supress lint

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Ruslan Yakushev <1664475+ruslany@users.noreply.github.com>
Co-authored-by: michimune <michimune@outlook.com>
Co-authored-by: Michimune Kohno <mikono@microsoft.com>
Co-authored-by: Mike Vu <mikevu@microsoft.com>
Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>
Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Mengjun Qin <767524684@qq.com>
Co-authored-by: Mengjun Qin <menqin@microsoft.com>
Co-authored-by: Taher Daroly <41846928+tdaroly@users.noreply.github.com>
Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
Co-authored-by: p-bouchon <107427816+p-bouchon@users.noreply.github.com>
Co-authored-by: p-bouchon <pbouchon@microsoft.com>
Co-authored-by: njucz <740360112@qq.com>
Co-authored-by: JJ <jijohn@microsoft.com>
Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com>
Co-authored-by: Mahmoud Desokey <desokey@yahoo.com>
Co-authored-by: Xingjian Wang <79332479+xwang971@users.noreply.github.com>
Co-authored-by: trajkobal <108365738+trajkobal@users.noreply.github.com>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Sep 27, 2022
Rename Post Action and Add Secrets Tags (Azure#20775)

* Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01

* Updates readme

* Updates API version in new specs and examples

* Add app diag to 2022-05-01 (Azure#18678)

* Add container apps diagnostics

* Fix validation errors

* Move Microsoft.App diag APIs to 2022-05-01

* Fix validation errors

* Fix validation errors

* Fix validation errors 3

* Change operationIds

Co-authored-by: Michimune Kohno <mikono@microsoft.com>

* Fix definition for customhostnameesult (Azure#19014)

* fix

* update

* more fix

* Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (Azure#19048)

* Correct Probe enums (Azure#18839)

* fix probe enums

* Fix revision mode enum

* Fix patch example

* Fix the casing of enums in the latest api version

* Change the parameter names to unblock Terraform release (Azure#19005)

* contianerapps: fixing swagger inconsistencies in 2022-01-01-preview

* containerapps: fixing inconsistencies in the 2022-03-01 swagger

* containerapps: updating the examples for 2022-01-01-preview

* containerapps: updating the examples to account for the updated parameter names

* containerapps: fixing linting

* fix probe enums

* Fix revision mode enum

* Fix the policheck error

* Revert "containerapps: fixing linting"

This reverts commit 3c4872f4a43fbe1a285830461f48d8c0a5ffeee8.

* Revert "containerapps: updating the examples for 2022-01-01-preview"

This reverts commit 9b81fbd65652d558c0296d72a63ca1a7c4850e3c.

* Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview"

This reverts commit 553fc551b3239598157238ed6246085748421b87.

* Undo changes to 2022-01-01-preview

* Fix one issue

* fix remaining inconsistency

* fix authConfig and sourceControl names

Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>
Co-authored-by: Mike Vu <mikevu@microsoft.com>

* Change param names

* Fix examples

* Fix CI errors

Co-authored-by: Mike Vu <mikevu@microsoft.com>
Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>

* Fix description in all API versions (Azure#19313)

* Fix description for ManagedEnvironment.Internal property (Azure#19307)

* Fix descriptions in all api versions

* Add traffic info to revisions api (Azure#19054)

* Add traffic info to a revision api

* Add deprecated prop

* Prettier fixes

* 1pdate based on new proposal

* Rename

* Change names

* minor fix

* Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (Azure#19360)

* Add httpReadBufferSize to dapr config

* remove nullable

* Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add new resources for 2022-06-01-preview (Azure#19494)

* update

* update

* update

* fix

* update

* update

* update

* update

* fix

* update

* update

* Enable Dapr AI Connection string for Microsoft.App connected environment (Azure#19974)

* Enable Dapr AI Connection string for Microsoft.App connected environment

* Fix dapr ai connection string

* remove read

* remove read permission of dapr ai connection string and instrument key for managed environment

* fixes for comments

* update (Azure#20013)

* Fixdescriptions on microsoft.app 2022 06 01 preview (Azure#20133)

* Fix casing for detector properties

* Fix descriptions

* Fix descriptions and detectorProperties in 2022-06-01-preview

* Added `secretsStoreComponent` in 2022-06-01 spec (Azure#20044)

* Added `secretsStoreComponent` in 2022-06-01 spec

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

* Fixed typos and added example of name/key

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

* Add custom domain configuration for managed environment (Azure#20149)

Co-authored-by: Mengjun Qin <menqin@microsoft.com>

* Add additional Dapr options (2022-06-01-preview) (Azure#19886)

* Add additional Dapr options

* Update examples for 2022-06-01-preview

* force ci

* force ci

* force ci

* adding ip-restriction feat (Azure#19841)

* adding ip-restriction feat

* remove from stable, add to preview

* fix lintDiff error

* fix modelvalidation error

* fix formatting changes

* rename names, add note to all allow or all deny

* fix spell check error

* update name and examples

* rename `ipAddress` to `ipAddressRange`

* making small change to re-run build pipeline

* trigger GitHub actions

* resolve comments

Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>

* Remove Traffic Labels from revisions because they haven't been impelemented (Azure#20261)

* Revert "Add traffic info to revisions api (Azure#19054)"

This reverts commit 056cc51226bf2eef3d3a7e7bdca875a4a571026b.

* Remove traffic labels from revisions

* Add property for tcp apps (Azure#20193)

* Add property for tcp apps

* Add scale

* Fix

* Fix

* Add Init Containers to common definitions (Azure#19855)

* add init containers to common definitions

* move changes to 06-01 preview

* remove repeated container definition

* fix allof syntax

* fix anonymous container definition

* fix lintdiff errors

* fix container allof syntax

* add more init examples

* split baseContainer definition

* remove description

Co-authored-by: p-bouchon <pbouchon@microsoft.com>

* Update container app provisioningstate (Azure#20411)

* update

* update

* add property: maxInactiveRevisions (Azure#20334)

* add property: maxInactiveRevisions

* update

* update

* Add premium sku related properties for managed environment (Azure#19770)

* Add premium sku related properties for managed environment

* Move sku to base property

* Add workloadProfileType

* Examples for managed environment

* Add container app example

* Fix workloadProfiles

* Add custom word

* Fix WorkloadProfileType references

* prettier fixes

* Fix workload profile

* Fix typo

* remove readonly property for workload profile

* Add object type

* nit: Fix description location

* Fix XmsIdentifierValidation

* Remove spaces from enum values

* Remove unwanted change

* Add aka ms url

* Update examples for workload profile type

* Fix rebase issue

* Fix json

* Update description and move location

* Remove provisioning state for node pool

* sku capacity explanation

* Remove capacity attribute

* Remove capacity attribute from required

* Mark sku property as required

* Add x-ms-identifiers

* Rename mimum and maximum

* Rename skutype to skuName

* Make sku property as optional

* Make workload profile type as string

* fix go SDK automation config

Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>

* Fix source control status code in 2022-06-01-preview. (Azure#20429)

* Remove 20220501 because we will not support it in server side (Azure#20427)

* remove

* update

* Added support for user defined routing (Azure#20464)

* Added support for user defined routing

* Added examples

* fixed JSON syntax

* syntax fix

* fixed vnetenvironment syntax

* fixed camel case

* case fix

* enum syntax

* fixed comma cases ManagedEnvironmentOutBoundType

* fixing casing

* Some more APIs (Azure#20448)

* new APIs to 06-01

* test fix

* more fixes

* add last active time for revision (Azure#20658)

* Add custom domain for connected env (Azure#20731)

* add custom domain

* fhcekout

* billingMeters - GET endpoint (Azure#20485)

* Swagger documentation for /locations/{location}/billingMeters - GET endpoint

* Add example, fix validation errors

* Fix ARM validation errors, code review comments

* Fix response validation

* add proxy resource properties

* Response formatting

* add default error response

* ARM Review feedback + small naming change for a property

* Change GB to GiB

* Rename Action

* secrets tag

* missed fix

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Ruslan Yakushev <1664475+ruslany@users.noreply.github.com>
Co-authored-by: michimune <michimune@outlook.com>
Co-authored-by: Michimune Kohno <mikono@microsoft.com>
Co-authored-by: Zunli Hu <zuh@microsoft.com>
Co-authored-by: Mike Vu <mikevu@microsoft.com>
Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>
Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Mengjun Qin <767524684@qq.com>
Co-authored-by: Mengjun Qin <menqin@microsoft.com>
Co-authored-by: Taher Daroly <41846928+tdaroly@users.noreply.github.com>
Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
Co-authored-by: p-bouchon <107427816+p-bouchon@users.noreply.github.com>
Co-authored-by: p-bouchon <pbouchon@microsoft.com>
Co-authored-by: njucz <740360112@qq.com>
Co-authored-by: JJ <jijohn@microsoft.com>
Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com>
Co-authored-by: Mahmoud Desokey <desokey@yahoo.com>
Co-authored-by: trajkobal <108365738+trajkobal@users.noreply.github.com>
azure-sdk pushed a commit to azure-sdk/azure-sdk-for-js that referenced this issue Sep 28, 2022
Availableworkloadprofiles - GET endpoint (Azure#20650)

* Adds base for updating Microsoft.App from version stable/2022-03-01 to version 2022-05-01

* Updates readme

* Updates API version in new specs and examples

* Add app diag to 2022-05-01 (Azure#18678)

* Add container apps diagnostics

* Fix validation errors

* Move Microsoft.App diag APIs to 2022-05-01

* Fix validation errors

* Fix validation errors

* Fix validation errors 3

* Change operationIds

Co-authored-by: Michimune Kohno <mikono@microsoft.com>

* Fix definition for customhostnameesult (Azure#19014)

* fix

* update

* more fix

* Cherry pick for the parameter name fixes for the 2022-03-01 and making the same fixes in 2022-05-01 (Azure#19048)

* Correct Probe enums (Azure#18839)

* fix probe enums

* Fix revision mode enum

* Fix patch example

* Fix the casing of enums in the latest api version

* Change the parameter names to unblock Terraform release (Azure#19005)

* contianerapps: fixing swagger inconsistencies in 2022-01-01-preview

* containerapps: fixing inconsistencies in the 2022-03-01 swagger

* containerapps: updating the examples for 2022-01-01-preview

* containerapps: updating the examples to account for the updated parameter names

* containerapps: fixing linting

* fix probe enums

* Fix revision mode enum

* Fix the policheck error

* Revert "containerapps: fixing linting"

This reverts commit 3c4872f4a43fbe1a285830461f48d8c0a5ffeee8.

* Revert "containerapps: updating the examples for 2022-01-01-preview"

This reverts commit 9b81fbd65652d558c0296d72a63ca1a7c4850e3c.

* Revert "contianerapps: fixing swagger inconsistencies in 2022-01-01-preview"

This reverts commit 553fc551b3239598157238ed6246085748421b87.

* Undo changes to 2022-01-01-preview

* Fix one issue

* fix remaining inconsistency

* fix authConfig and sourceControl names

Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>
Co-authored-by: Mike Vu <mikevu@microsoft.com>

* Change param names

* Fix examples

* Fix CI errors

Co-authored-by: Mike Vu <mikevu@microsoft.com>
Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>

* Fix description in all API versions (Azure#19313)

* Fix description for ManagedEnvironment.Internal property (Azure#19307)

* Fix descriptions in all api versions

* Add traffic info to revisions api (Azure#19054)

* Add traffic info to a revision api

* Add deprecated prop

* Prettier fixes

* 1pdate based on new proposal

* Rename

* Change names

* minor fix

* Add httpReadBufferSize to dapr config in Microsoft.App-2022-05-01 (Azure#19360)

* Add httpReadBufferSize to dapr config

* remove nullable

* Adds base for updating Microsoft.App from version stable/2022-05-01 to version 2022-06-01-preview

* Updates readme

* Updates API version in new specs and examples

* Add new resources for 2022-06-01-preview (Azure#19494)

* update

* update

* update

* fix

* update

* update

* update

* update

* fix

* update

* update

* Enable Dapr AI Connection string for Microsoft.App connected environment (Azure#19974)

* Enable Dapr AI Connection string for Microsoft.App connected environment

* Fix dapr ai connection string

* remove read

* remove read permission of dapr ai connection string and instrument key for managed environment

* fixes for comments

* update (Azure#20013)

* Fixdescriptions on microsoft.app 2022 06 01 preview (Azure#20133)

* Fix casing for detector properties

* Fix descriptions

* Fix descriptions and detectorProperties in 2022-06-01-preview

* Added `secretsStoreComponent` in 2022-06-01 spec (Azure#20044)

* Added `secretsStoreComponent` in 2022-06-01 spec

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

* Fixed typos and added example of name/key

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>

* Add custom domain configuration for managed environment (Azure#20149)

Co-authored-by: Mengjun Qin <menqin@microsoft.com>

* Add additional Dapr options (2022-06-01-preview) (Azure#19886)

* Add additional Dapr options

* Update examples for 2022-06-01-preview

* force ci

* force ci

* force ci

* adding ip-restriction feat (Azure#19841)

* adding ip-restriction feat

* remove from stable, add to preview

* fix lintDiff error

* fix modelvalidation error

* fix formatting changes

* rename names, add note to all allow or all deny

* fix spell check error

* update name and examples

* rename `ipAddress` to `ipAddressRange`

* making small change to re-run build pipeline

* trigger GitHub actions

* resolve comments

Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>

* Remove Traffic Labels from revisions because they haven't been impelemented (Azure#20261)

* Revert "Add traffic info to revisions api (Azure#19054)"

This reverts commit 056cc51226bf2eef3d3a7e7bdca875a4a571026b.

* Remove traffic labels from revisions

* Add property for tcp apps (Azure#20193)

* Add property for tcp apps

* Add scale

* Fix

* Fix

* Add Init Containers to common definitions (Azure#19855)

* add init containers to common definitions

* move changes to 06-01 preview

* remove repeated container definition

* fix allof syntax

* fix anonymous container definition

* fix lintdiff errors

* fix container allof syntax

* add more init examples

* split baseContainer definition

* remove description

Co-authored-by: p-bouchon <pbouchon@microsoft.com>

* Update container app provisioningstate (Azure#20411)

* update

* update

* add property: maxInactiveRevisions (Azure#20334)

* add property: maxInactiveRevisions

* update

* update

* Add premium sku related properties for managed environment (Azure#19770)

* Add premium sku related properties for managed environment

* Move sku to base property

* Add workloadProfileType

* Examples for managed environment

* Add container app example

* Fix workloadProfiles

* Add custom word

* Fix WorkloadProfileType references

* prettier fixes

* Fix workload profile

* Fix typo

* remove readonly property for workload profile

* Add object type

* nit: Fix description location

* Fix XmsIdentifierValidation

* Remove spaces from enum values

* Remove unwanted change

* Add aka ms url

* Update examples for workload profile type

* Fix rebase issue

* Fix json

* Update description and move location

* Remove provisioning state for node pool

* sku capacity explanation

* Remove capacity attribute

* Remove capacity attribute from required

* Mark sku property as required

* Add x-ms-identifiers

* Rename mimum and maximum

* Rename skutype to skuName

* Make sku property as optional

* Make workload profile type as string

* fix go SDK automation config

Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>

* Fix source control status code in 2022-06-01-preview. (Azure#20429)

* Swagger documentation for /locations/{location}/billingMeters - GET endpoint

* Add example, fix validation errors

* Fix ARM validation errors, code review comments

* Fix response validation

* Remove 20220501 because we will not support it in server side (Azure#20427)

* remove

* update

* add proxy resource properties

* Response formatting

* Added support for user defined routing (Azure#20464)

* Added support for user defined routing

* Added examples

* fixed JSON syntax

* syntax fix

* fixed vnetenvironment syntax

* fixed camel case

* case fix

* enum syntax

* fixed comma cases ManagedEnvironmentOutBoundType

* fixing casing

* add default error response

* Add available workprofiles -GET endpoint

* Remove duplicate schema name WorkloadProfile

* Change memoryGiB to memoryGB as suggested in code review

* Add x-ms-pageable - nextLink support to not introduce breaking changes in the future

* rename to memory in GiB because our case is Gibibytes base 1024

* change friendlyName to displayName

* Some more APIs (Azure#20448)

* new APIs to 06-01

* test fix

* more fixes

* Add new property to the response object

* add last active time for revision (Azure#20658)

* Add custom domain for connected env (Azure#20731)

* add custom domain

* fhcekout

* billingMeters - GET endpoint (Azure#20485)

* Swagger documentation for /locations/{location}/billingMeters - GET endpoint

* Add example, fix validation errors

* Fix ARM validation errors, code review comments

* Fix response validation

* add proxy resource properties

* Response formatting

* add default error response

* ARM Review feedback + small naming change for a property

* Change GB to GiB

* Change the boolean value for default to enum

* change error response to v3/ErrorResponse

* Fix 2022-06-01-preview branch merge conflicts (Azure#20773)

* Reset

* more fixes

* More fixes

* another conflict fix

* Fix old preview version

* fix 2022-03-01

Signed-off-by: ItalyPaleAle <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Ruslan Yakushev <1664475+ruslany@users.noreply.github.com>
Co-authored-by: michimune <michimune@outlook.com>
Co-authored-by: Michimune Kohno <mikono@microsoft.com>
Co-authored-by: Zunli Hu <zuh@microsoft.com>
Co-authored-by: Mike Vu <mikevu@microsoft.com>
Co-authored-by: tombuildsstuff <git@tom.ibuildstuff.eu>
Co-authored-by: Ahmed ElSayed <ahmels@microsoft.com>
Co-authored-by: LaylaLiu-gmail <38268900+LaylaLiu-gmail@users.noreply.github.com>
Co-authored-by: Alessandro (Ale) Segala <43508+ItalyPaleAle@users.noreply.github.com>
Co-authored-by: Mengjun Qin <767524684@qq.com>
Co-authored-by: Mengjun Qin <menqin@microsoft.com>
Co-authored-by: Taher Daroly <41846928+tdaroly@users.noreply.github.com>
Co-authored-by: Taher Darolywala <tdarolywala@microsoft.com>
Co-authored-by: zhenqxuMSFT <zhenqxu@microsoft.com>
Co-authored-by: p-bouchon <107427816+p-bouchon@users.noreply.github.com>
Co-authored-by: p-bouchon <pbouchon@microsoft.com>
Co-authored-by: njucz <740360112@qq.com>
Co-authored-by: JJ <jijohn@microsoft.com>
Co-authored-by: Chenjie Shi <tadelesh.shi@live.cn>
Co-authored-by: yalixiang <88011184+yalixiang@users.noreply.github.com>
Co-authored-by: Mahmoud Desokey <desokey@yahoo.com>
Co-authored-by: Xingjian Wang <79332479+xwang971@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Communication test-reliability Issue that causes tests to be unreliable
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants