Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Search Documents] Build test package failing in nightly runs #20137

Closed
v-yilinhu opened this issue Jan 30, 2022 · 5 comments
Closed

[Search Documents] Build test package failing in nightly runs #20137

v-yilinhu opened this issue Jan 30, 2022 · 5 comments
Assignees
Labels
Client This issue points to a problem in the data-plane of the library. Search test-reliability Issue that causes tests to be unreliable

Comments

@v-yilinhu
Copy link

Search Documents nightly test runs are failing with:

Rush Multi-Project Build Tool 5.61.2 - Node.js 14.18.3 (LTS)

"tsc -p ."

utils/recordedClient.ts(14,39): error TS2306: File '/mnt/vss/_work/1/s/sdk/search/search-documents/test/public/utils/setup.ts' is not a module.
The script failed with exit code 2

For more details check here:

@ghost ghost added the needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. label Jan 30, 2022
@v-xuto v-xuto added Client This issue points to a problem in the data-plane of the library. Search test-reliability Issue that causes tests to be unreliable and removed needs-triage Workflow: This is a new issue that needs to be triaged to the appropriate team. labels Jan 30, 2022
@sarangan12
Copy link
Member

Thanks @v-xuto for reporting this issue. I will look into this and update

@sarangan12
Copy link
Member

I checked the Failing job. It works fine for the following combination:

  1. Windows 2019 + node 14.18.3
  2. Ubuntu 2004 + node 14.18.3
  3. Windows 2019 + node 14.18.3

But, the code is not working only with the combination: Ubuntu 2004 + node 14.18.3. This is actually surprising. I am investigating the issue and update this issue soon

@sarangan12
Copy link
Member

The code that is causing the issue is introduced on 01/28/2022 in PR #20125 as part of migrating the search-documents SDK to the new recorder by @HarshaNalluru. The code is straight-forward and should not be causing issues. I will investigate this further and update the issue.

@HarshaNalluru
Copy link
Member

@sarangan12 Oops, I didn't see them probably because I didn't run live tests/min-max as part of my PR.

Let me know if you're not able to resolve the issue, or if need more(my) eyes.

@sarangan12
Copy link
Member

I have synched with Harsha offline. The error is weird and needs more investigation.At present, I need to focus on Shim Project. So, In order to prioritize the tasks and at the same time remove the CI failures, I have reverted the changes done on Friday with the PR #20149.

I have also confirmed that the CI is passing now. @HarshaNalluru will be focusing on the recorder task and at that time will ensure that this CI error does not happen again. No pending action items on this issue. Resolving this. Thanks

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Client This issue points to a problem in the data-plane of the library. Search test-reliability Issue that causes tests to be unreliable
Projects
None yet
Development

No branches or pull requests

4 participants