[Search Documents] Migrating search-documents to the new recorder #20125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
HarshaNalluru
requested review from
benbp and
praveenkuttappan
as code owners
|
What do you think about doing al recorder start and setup inside createClient? Maybe it can take the recorder as parameter |
|
Sounds good |
23 tasks
sarangan12
requested changes
Jan 28, 2022
| import { delay, serviceVersions } from "../../../src/serviceUtils"; | ||
| import { versionsToTest } from "@azure/test-utils"; | ||
|
|
||
| const TEST_INDEX_NAME = isLiveMode() ? createRandomIndexName() : "hotel-live-test1"; |
There was a problem hiding this comment.
Could you please expand why this is removed? The CreateRandonIndexName method should be called only for live mode. But now it seems it is getting called even for the playback mode which will cause issues
There was a problem hiding this comment.
< Discussed offline 😎 >
sarangan12
approved these changes
Jan 28, 2022
|
Spoke with Harsha offline. Changes look good. Approving it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Packages impacted by this PR
search-documents
Issues associated with this PR
#19859
Describe the problem that is addressed by this PR
Migrating search-documents to the new recorder
What are the possible designs available to address the problem? If there are more than one possible design, why was the one in this PR chosen?
N/A
Are there test cases added in this PR? (If not, why?)
N/A
Provide a list of related PRs (if any)
N/A
Command used to generate this PR:**(Applicable only to SDK release request PRs)
Checklists