[communication] Fix SDK_VERSION value #12546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominikMe
requested review from
ankitarorabit,
RezaJooyandeh and
a team
as code owners
ghost
added
the
whisper6284
reviewed
Nov 13, 2020
| import { apiVersion } from "./generated/src/models/parameters"; | ||
|
|
||
| export const SDK_VERSION: string = apiVersion.mapper.defaultValue; | ||
| export const SDK_VERSION: string = "1.0.0-beta.3"; |
There was a problem hiding this comment.
What is the logic of the other repos to hardcode the SDK version?
This feels trappy where updating the SDK version requires changes in an unknown number of places.
There was a problem hiding this comment.
It's not great but the other JS libraries hard-code too.
There are at least 3 changes to make with a version bump: Changelog, package-version for autorest, and SDK_VERSION here.
|
/azp run js - communication - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We mistakingly used the service api version for constructing the SDK user agent string.
Following the pattern of other services and hard-coding the version string.