[Key Vault] Full LRO refactoring #12630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sadasant
added
Client
xirzec
approved these changes
Nov 20, 2020
| if (endTime) { | ||
| state.isCompleted = true; | ||
| } | ||
| if (error && error.message) { |
There was a problem hiding this comment.
what happens if error has an empty message? Does it never finish? Do we ignore it?
There was a problem hiding this comment.
I think the error is only valid if it has a message. I'll ask the team!
There was a problem hiding this comment.
I made an issue! #12693 I'll follow up before the next Key Vault release.
| } | ||
| if (error && error.message) { | ||
| state.isCompleted = true; | ||
| state.error = new Error(error.message); |
There was a problem hiding this comment.
Curious why we recreate the error
There was a problem hiding this comment.
The error we receive is of the type ErrorModel, which is some sort of error tree:
/**
* The key vault server error.
*/
export interface ErrorModel {
/**
* The error code.
*/
readonly code?: string;
/**
* The error message.
*/
readonly message?: string;
/**
* The key vault server error.
*/
readonly innerError?: ErrorModel;
}I'll leave this as creating a new error for now.
There was a problem hiding this comment.
I made an issue! #12693 I'll follow up before the next Key Vault release.
bterlson
approved these changes
Nov 23, 2020
|
@bterlson wow! thank you for that review 🙏🙌❤ |
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jan 26, 2021
add vmss capabilities to force delete (Azure#12630)
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jan 26, 2021
add vmss capabilities to force delete (Azure#12630)
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jan 26, 2021
add vmss capabilities to force delete (Azure#12630)
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jan 26, 2021
add vmss capabilities to force delete (Azure#12630)
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jan 26, 2021
add vmss capabilities to force delete (Azure#12630)
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-js
that referenced
this pull request
Jan 26, 2021
add vmss capabilities to force delete (Azure#12630)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the Key Vault Keys LRO refactoring PR (link), this PR refactors all of the LROs in the other Key Vault clients. It also cleans up the initial refactor of the Key Vault Keys LROs.
There are some small changes in the public API, but they're only renames.
I'll leave in draft for a while since we're not releasing Key Vault so soon.