Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add web-pubsub to CI, update samples #15000

Merged
merged 9 commits into from
Apr 23, 2021
Merged

Conversation

bterlson
Copy link
Member

@bterlson bterlson commented Apr 23, 2021

Preparing to release the first beta package 😁

@willmtemple found that the product slugs used weren't initialized, removing them for now. @vicancy can you follow up with the docs team to add the proper product slugs for the service (presumably azure-web-pubsub)?

Regenerated samples and found that web-pubsub-express didn't check in the "camera ready" samples", so adding them here.

@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run js - [service] - ci

@bterlson
Copy link
Member Author

/azp run prepare-pipelines

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bterlson
Copy link
Member Author

/azp run js - web-pubsub - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@bterlson bterlson changed the title Add web-pubsub to CI Add web-pubsub to CI, update samples Apr 23, 2021
Copy link
Member

@witemple-msft witemple-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bterlson bterlson merged commit e0b362b into Azure:master Apr 23, 2021
jay-most pushed a commit to jay-most/azure-sdk-for-js that referenced this pull request Apr 26, 2021
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Jun 28, 2021
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Jun 28, 2021
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Jun 28, 2021
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Jun 28, 2021
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Jun 28, 2021
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Jun 28, 2021
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-js that referenced this pull request Jun 28, 2021
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants