-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add web-pubsub to CI, update samples #15000
Conversation
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
/azp run prepare-pipelines |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run js - web-pubsub - ci |
Azure Pipelines successfully started running 1 pipeline(s). |
8077573
to
7dfb74d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
alertsmanagement,applicationinsights,attestation,batch,cost-management,netapp,synapse (Azure#15000)
Preparing to release the first beta package 😁
@willmtemple found that the product slugs used weren't initialized, removing them for now. @vicancy can you follow up with the docs team to add the proper product slugs for the service (presumably
azure-web-pubsub
)?Regenerated samples and found that web-pubsub-express didn't check in the "camera ready" samples", so adding them here.