[Identity] Attempting to fix an issue with CI testing #15547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
jeremymeng
approved these changes
Jun 3, 2021
|
Hello @sadasant! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
/check-enforcer reset |
|
/check-enforcer override |
ghost
pushed a commit
that referenced
this pull request
Jun 5, 2021
… mock-fs (#15571) Recently we found an issue on our CI build for Node 16.3.0, which boiled down to one unit test specific to Identity: #15547 After some investigation, it is clear that Node 16.3.0 has some incompatibility with mock-fs: tschaub/mock-fs#332 In the mean time, to add this test again, we can simply create a file, point to it and delete it at the end. This should work in all versions of Node, and it means one less dev-dependency for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here’s a build with this issue: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=925971&view=ms.vss-test-web.build-test-results-tab&runId=19921706&resultId=100040&paneView=debug
There aren’t clear indicators of what could be causing the issue.
This PR attempts to keep the environment untouched while we run our tests. We were generally doing it, but we forgot to do it for this environment variable referenced in these changes.If this isn’t the fix I would be comfortable skipping this for now.I’m skipping this test now.