[tracing] - Remove spanContext from our public API #19786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
maorleger
requested review from
bterlson,
HarshaNalluru,
jeremymeng,
ramya-rao-a,
sadasant,
timovv and
xirzec
as code owners
|
API changes have been detected in |
|
API changes have been detected in |
maorleger
deleted the
feature/core-tracing-rewrite-without-spanContext
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taken from #19734 (comment) - this demonstrates what that might look like
This PR removes
TracingSpanContextfrom our public types and relies on TracingContext and runtime checks to serialize and deserialize a TracingSpan