Deserialize custom dimensions from application insights API response (#…

…14917) * Deserialize custom dimensions from application insights API response. Fixes #13042 * Test non-empty CustomDimensions from application insights API response Co-authored-by: Oleg Deribas <olegd@superoffice.com>
Azure · Sep 17, 2020 · 58a48f0 · 58a48f0
1 parent 3540eb4
commit 58a48f0
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 0 deletions.
diff --git a/...Azure.ApplicationInsights.Query/src/Customized/Models/EventsResultDataCustomDimensions.cs b/...Azure.ApplicationInsights.Query/src/Customized/Models/EventsResultDataCustomDimensions.cs
@@ -0,0 +1,27 @@
+using System.Collections.Generic;
+using Newtonsoft.Json;
+using Newtonsoft.Json.Linq;
+
+namespace Microsoft.Azure.ApplicationInsights.Query.Models
+{
+    public partial class EventsResultDataCustomDimensions
+    {
+#pragma warning disable CS0649 // Field is never assigned to, and will always have its default value
+        [JsonExtensionData]
+        private IDictionary<string, JToken> _customDimensionsValues;
+#pragma warning restore CS0649 // Field is never assigned to, and will always have its default value
+
+        public IEnumerable<string> Keys => _customDimensionsValues?.Keys;
+
+        public bool TryGetValue(string key, out string value)
+        {
+            if (_customDimensionsValues != null && _customDimensionsValues.TryGetValue(key, out var jToken))
+            {
+                value = jToken?.ToString();
+                return true;
+            }
+            value = null;
+            return false;
+        }
+    }
+}
diff --git a/...ts/Microsoft.Azure.ApplicationInsights.Query/tests/ScenarioTests/Events/EventsTestBase.cs b/...ts/Microsoft.Azure.ApplicationInsights.Query/tests/ScenarioTests/Events/EventsTestBase.cs
@@ -35,6 +35,9 @@ protected void AssertEvent(EventsResultData evnt, string expectedType)
 
             Assert.NotNull(evnt.Timestamp);
             // CustomDimensions & CustomMeasurements can be null
+            if (evnt.CustomDimensions != null && evnt.CustomDimensions.TryGetValue("ProcessId", out var value)) {
+                Assert.NotNull(value);
+            }
 
             // Operation
             if (expectedType != EventType.CustomEvents && expectedType != EventType.PageViews &&