Skip to content

Commit

Permalink
Azure.Provisioning.Sql - make *FirewallRule properties settable (#45933)
Browse files Browse the repository at this point in the history
These two don't inherit off ResourceData and weren't correctly being flattened. It therefore looked like their properties were never settable.
  • Loading branch information
tg-msft committed Sep 12, 2024
1 parent 50a9851 commit fa3fac3
Show file tree
Hide file tree
Showing 7 changed files with 27 additions and 166 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -417,21 +417,12 @@ public enum InstancePoolLicenseType
public partial class IPv6FirewallRule : Azure.Provisioning.Primitives.Resource
{
public IPv6FirewallRule(string resourceName, string? resourceVersion = null, Azure.Provisioning.ProvisioningContext? context = null) : base (default(string), default(Azure.Core.ResourceType), default(string), default(Azure.Provisioning.ProvisioningContext)) { }
public Azure.Provisioning.BicepValue<string> EndIPv6Address { get { throw null; } }
public Azure.Provisioning.BicepValue<Azure.Core.ResourceIdentifier> Id { get { throw null; } }
public Azure.Provisioning.BicepValue<string> Name { get { throw null; } set { } }
public Azure.Provisioning.Sql.SqlServer? Parent { get { throw null; } set { } }
public Azure.Provisioning.BicepValue<string> StartIPv6Address { get { throw null; } }
public static Azure.Provisioning.Sql.IPv6FirewallRule FromExisting(string resourceName, string? resourceVersion = null) { throw null; }
}
public partial class IPv6FirewallRuleData : Azure.Provisioning.Primitives.ProvisioningConstruct
{
public IPv6FirewallRuleData() : base (default(Azure.Provisioning.ProvisioningContext)) { }
public Azure.Provisioning.BicepValue<string> EndIPv6Address { get { throw null; } set { } }
public Azure.Provisioning.BicepValue<Azure.Core.ResourceIdentifier> Id { get { throw null; } }
public Azure.Provisioning.BicepValue<string> Name { get { throw null; } set { } }
public Azure.Provisioning.BicepValue<Azure.Core.ResourceType> ResourceType { get { throw null; } }
public Azure.Provisioning.Sql.SqlServer? Parent { get { throw null; } set { } }
public Azure.Provisioning.BicepValue<string> StartIPv6Address { get { throw null; } set { } }
public static Azure.Provisioning.Sql.IPv6FirewallRule FromExisting(string resourceName, string? resourceVersion = null) { throw null; }
}
public enum JobAgentState
{
Expand Down Expand Up @@ -1633,24 +1624,15 @@ public enum SqlDayOfWeek
public partial class SqlFirewallRule : Azure.Provisioning.Primitives.Resource
{
public SqlFirewallRule(string resourceName, string? resourceVersion = null, Azure.Provisioning.ProvisioningContext? context = null) : base (default(string), default(Azure.Core.ResourceType), default(string), default(Azure.Provisioning.ProvisioningContext)) { }
public Azure.Provisioning.BicepValue<string> EndIPAddress { get { throw null; } }
public Azure.Provisioning.BicepValue<string> EndIPAddress { get { throw null; } set { } }
public Azure.Provisioning.BicepValue<Azure.Core.ResourceIdentifier> Id { get { throw null; } }
public Azure.Provisioning.BicepValue<string> Name { get { throw null; } set { } }
public Azure.Provisioning.Sql.SqlServer? Parent { get { throw null; } set { } }
public Azure.Provisioning.BicepValue<string> StartIPAddress { get { throw null; } }
public Azure.Provisioning.BicepValue<string> StartIPAddress { get { throw null; } set { } }
public static Azure.Provisioning.Sql.SqlFirewallRule FromExisting(string resourceName, string? resourceVersion = null) { throw null; }
[System.ComponentModel.EditorBrowsableAttribute(System.ComponentModel.EditorBrowsableState.Never)]
public override Azure.Provisioning.Primitives.ResourceNameRequirements GetResourceNameRequirements() { throw null; }
}
public partial class SqlFirewallRuleData : Azure.Provisioning.Primitives.ProvisioningConstruct
{
public SqlFirewallRuleData() : base (default(Azure.Provisioning.ProvisioningContext)) { }
public Azure.Provisioning.BicepValue<string> EndIPAddress { get { throw null; } set { } }
public Azure.Provisioning.BicepValue<Azure.Core.ResourceIdentifier> Id { get { throw null; } }
public Azure.Provisioning.BicepValue<string> Name { get { throw null; } set { } }
public Azure.Provisioning.BicepValue<Azure.Core.ResourceType> ResourceType { get { throw null; } }
public Azure.Provisioning.BicepValue<string> StartIPAddress { get { throw null; } set { } }
}
public enum SqlMinimalTlsVersion
{
[System.Runtime.Serialization.DataMemberAttribute(Name="None")]
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

This file was deleted.

This file was deleted.

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ protected override void Customize()
RemoveProperty<FailoverGroupResource>("ReadOnlyEndpointFailoverPolicy");
RemoveProperty<FailoverGroupResource>("Databases");
RemoveProperty<GeoBackupPolicyResource>("GeoBackupPolicyName");
RemoveProperty<IPv6FirewallRuleResource>("Data");
RemoveProperty<LedgerDigestUploadResource>("LedgerDigestUploads");
RemoveProperty<LogicalDatabaseTransparentDataEncryptionResource>("TdeName");
RemoveProperty<LongTermRetentionPolicyResource>("PolicyName");
Expand Down Expand Up @@ -55,7 +54,6 @@ protected override void Customize()
RemoveProperty<SqlDatabaseVulnerabilityAssessmentResource>("VulnerabilityAssessmentName");
RemoveProperty<SqlDatabaseVulnerabilityAssessmentRuleBaselineResource>("BaselineName");
RemoveProperty<SqlDatabaseVulnerabilityAssessmentRuleBaselineResource>("RuleId");
RemoveProperty<SqlFirewallRuleResource>("Data");