Fix Key Vault live tests #11415
Merged
Fix Key Vault live tests #11415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Occasional issue with live tests caused by test assemblies running concurrently. We need to skip managed keys and secrets (only secrets was actually failing, but keys could as well) since certificates may be getting deleted simultaneously.
pakrym
approved these changes
Apr 21, 2020
|
Should we create a second KV for samples that would not have managed keys in them? |
|
Managed keys and secrets are just those tied to certificates. In order to avoid managed keys and secrets, certificates would need to be in their own KV and I don't think it's worth it. I have considered, though, creating a separate KV with soft delete disabled because some of our code works differently (or not at all, like purge and recover operations) but it means a significant rewrite/refactoring of test code, because even the clean up assumes soft delete. It's not something we'd likely have time to do, and probably isn't worth the time investment after an internal discussion. |
|
/check-enforcer reset |
|
/check-enforcer evaluate |
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-net
that referenced
this pull request
Nov 12, 2020
Revert: spec changes for Libmary Management in bigDataPool (Azure#11612) * Revert "attributes added in LibraryInfo in BigDataPool specs (Azure#11415)" This reverts commit 5d48a7dc324dd221d5e0455e3947c5fc39084132. * Revert "Custom Library support in Spark pool (Azure#11172)" This reverts commit c653ee788c4dd74ede34ff17e64e7c0c45681e3e. Co-authored-by: Navneet Singh <navsi@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Occasional issue with live tests caused by test assemblies running
concurrently. We need to skip managed keys and secrets (only secrets was
actually failing, but keys could as well) since certificates may be
getting deleted simultaneously.