Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Event Hubs Client] Connection String SAS Support (Preview.3 Base) #14796

Merged

Conversation

jsquire
Copy link
Member

@jsquire jsquire commented Sep 2, 2020

Summary

The focus of these changes is to build on the source used for the preview.3 release, adding support for a precomputed shared access signature token to
be used as part of the connection string.

Last Upstream Rebase

Wednesday, September 2, 9:58am (EDT)

References and Related Issues

@jsquire jsquire added Event Hubs Client This issue points to a problem in the data-plane of the library. labels Sep 2, 2020
@jsquire jsquire added this to the [2020] September milestone Sep 2, 2020
@jsquire jsquire self-assigned this Sep 2, 2020
@jsquire
Copy link
Member Author

jsquire commented Sep 2, 2020

Once merged into the 5.2.0 branch, I'll cherry-pick over to master and open a separate PR.

Copy link
Member

@christothes christothes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor suggestion

The focus of these changes is to build on the source used for the preview.3
release, adding support for a precomputed shared access signature token to
be used as part of the connection string.
@jsquire
Copy link
Member Author

jsquire commented Sep 3, 2020

/azp run net - eventhub - tests

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@jsquire jsquire merged commit b705fa0 into Azure:release/eventhubs-5.2.0 Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants