Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add sub library to include azure.resourcemanager #23019

Merged
merged 2 commits into from
Jul 30, 2021
Merged

add sub library to include azure.resourcemanager #23019

merged 2 commits into from
Jul 30, 2021

Conversation

m-nash
Copy link
Member

@m-nash m-nash commented Jul 30, 2021

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

  • Please open PR in Draft mode if it is:
    • Work in progress or not intended to be merged.
    • Encountering multiple pipeline failures and working on fixes.
  • If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.
  • I have read the contribution guidelines.
  • The pull request does not introduce breaking changes.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

SDK Generation Guidelines

  • The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
  • The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

  • Include updated management metadata.
  • Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

  • If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.

  • If the check fails at the Verify Code Generation step, please ensure:

    • Do not modify any code in generated folders.
    • Do not selectively include/remove generated files in the PR.
    • Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
      Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.

    Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:

      `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

@m-nash m-nash merged commit 9abcc27 into main Jul 30, 2021
@m-nash m-nash deleted the mnash-6085-addMgmtSubFlag branch July 30, 2021 22:52
weshaggard
weshaggard reviewed Jul 30, 2021
View reviewed changes
eng/Directory.Build.Common.props
@@ -119,6 +121,10 @@
<RequiredTargetFrameworks Condition="'$(OS)' == 'Windows_NT'">net461;netcoreapp3.1;net5.0</RequiredTargetFrameworks>
</PropertyGroup>

<ItemGroup Condition="'$(IsMgmtSubLibrary)' == 'true' and !$(MSBuildProjectName.Equals('Azure.ResourceManager.Tests'))">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just exclude test projects? It seems like you opted out a bunch of test projects directly.

azure-sdk pushed a commit to azure-sdk/azure-sdk-for-net that referenced this pull request Apr 18, 2023
@Kartik-715 @cakarata
@payalguptapg @AnshulVermaa @Sandido @younghyun5756 @krishnak-msft @linugeorgeofficial @vatsan28 @vivlingaiah @mimckitt
CodeGen from PR 22885 in Azure/azure-rest-api-specs
7f0d854 
Feature/cplat 2023 03 01 (Azure#22885)

* copy last version to 2023-03-01 folder

* update version reference in the new folder

* update versions reference in the new folder

* add new readme tag with new version

* sync with updates made to 2022-11-01 version

* fix generation error

* fix duplicate enum name thru c# directive instead.

* make all the changes to this version that was made to the last version (2022-11-01) to address modelvalidation errors

* update

* Revert "update"

This reverts commit 08417d3ed412ab63c7ee7bdb712ad756ded03c97.

* Added $expand option in ListAllVMs and ListAllVMs in RG (Azure#22800)

* Added $expand option in ListAllVMs and ListAllVMs in RG

* Update virtualMachine.json

* dedicatedHost Resize feature (Azure#23268)

* dedicatedHost Resize feature

* DedicatedHost Sku renamed to size and resolved lint errors.

* reviewer comments

* httpMethod fix

* Add property for VM (Azure#22882) (Azure#23329)

Co-authored-by: payalguptapg <126145083+payalguptapg@users.noreply.github.com>

* Add Reapply for VMSS (Azure#22344)

* Add Reapply for VMSS

* Prettier fix

* Update examples

* Address review comments 01

* Use typical resourceGroupName parameter.

* Address review comments - Rename examples

* Remove <br> syntax from many descriptions in CRP swagger files (Azure#23019)

* up to computeRPCommon

* all but computeRPCommons

* computerpcommon

* vmss clean

* common clean

* vmss try n

* trying only \n

* remove \n as it messes with rest docs

* cleanup 2022-11-01 accidents

* cleanups 2023

* remove ID from Update objects that do not have ID (Azure#23078)

* update

* add identifiers

---------

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>

* Origin/feature/cplat 2023 03 01 (Azure#23203)

* Update virtualMachine.json

Added missing property for 
Additional properties not allowed: provisionAfterExtensions
Json path: $.value[*].properties.provisionAfterExtensions

* added missing property for provisionAfterExtensions

* add locatoin in VirtualMachineScaleSetVMExtension

* fixed issue of x-ms-mutability

---------

Co-authored-by: Younghyun Kim <younghyunkim@microsoft.com>

* Add securityPostureReference (Azure#23106)

* [RestorePoints] Adding Encryption, Source Details, HyperVGeneration and WriteAccelerated for Restore Point (Azure#23303)

* Restore Point Encryption Details

* Modified descriptions and made DiskRestorePointProperties as input property

* Renaming object and adding type

* Renaming DiskRestorePointProperties

* making DiskRestorePoint.id readOnly

* Modifying reference

* Running Prettier

* Renaming EncryptionType

* Adding HyperVGeneration and WriteAcceleratorEnabled (prchin)

* Add optional parameter hibernate to vmss deallocate api (Azure#23409)

* Add optional parameter hibernate to vmss deallocate api

* Fix with prettier

* update example for vmss deallocate

* Add Spot Related Properties to VMSS PATCH

* prettier and lintDiff suppressions

* retry lintDiff suppression

* lint diff suppression retry

* Add managed identities parameters for blobs, add treatFailureAsDeploymentFailure flag for Run Command (Azure#23557)

* Add managed identities inputs for script, errorBlob, outputBlob

* Add treatFailureAsDeploymentFailure flag

* Update proximityPlacementGroup.json (Azure#23556)

* Update proximityPlacementGroup.json

* Update proximityPlacementGroup.json

* Update proximityPlacementGroup.json

---------

Co-authored-by: Theodore Chang <theodore.l.chang@gmail.com>
Co-authored-by: Kartik Gupta <31189137+Kartik-715@users.noreply.github.com>
Co-authored-by: cakarata <47228825+cakarata@users.noreply.github.com>
Co-authored-by: payalguptapg <126145083+payalguptapg@users.noreply.github.com>
Co-authored-by: Anshul Verma <88476874+AnshulVermaa@users.noreply.github.com>
Co-authored-by: Adam Sandor <adsandor@microsoft.com>
Co-authored-by: younghyun5756 <102988755+younghyun5756@users.noreply.github.com>
Co-authored-by: Younghyun Kim <younghyunkim@microsoft.com>
Co-authored-by: krishnak-msft <127885427+krishnak-msft@users.noreply.github.com>
Co-authored-by: Linu George <127192938+linugeorgeofficial@users.noreply.github.com>
Co-authored-by: vatsan28 <vatsan9228@gmail.com>
Co-authored-by: Viv Lingaiah <viv.lingaiah@gmail.com>
Co-authored-by: Micah McKittrick <32313503+mimckitt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weshaggard weshaggard weshaggard left review comments

@nisha-bhatia nisha-bhatia nisha-bhatia approved these changes

@chidozieononiwu chidozieononiwu Awaiting requested review from chidozieononiwu

@danieljurek danieljurek Awaiting requested review from danieljurek

@archerzz archerzz Awaiting requested review from archerzz archerzz is a code owner

@ArcturusZhang ArcturusZhang Awaiting requested review from ArcturusZhang ArcturusZhang is a code owner

@fengzhou-msft fengzhou-msft Awaiting requested review from fengzhou-msft

@yungezz yungezz Awaiting requested review from yungezz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@m-nash @weshaggard @nisha-bhatia