Changes in StartRecordingCall Request models for Mixed Audio Only Feature #23354

ninikasharma · 2021-08-17T00:42:19Z

…udio Feature.

All SDK Contribution checklist:

This checklist is used to make sure that common guidelines for a pull request are followed.

Please open PR in Draft mode if it is:
- Work in progress or not intended to be merged.
- Encountering multiple pipeline failures and working on fixes.
If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above. Here is the swagger spec PR - Changes for Mixed Audio Recordings Release azure-rest-api-specs#15618
I have read the contribution guidelines.
The pull request does not introduce breaking changes.

General Guidelines and Best Practices

Title of the pull request is clear and informative.
There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

Pull request includes test coverage for the included changes.

SDK Generation Guidelines

The generate.cmd file for the SDK has been updated with the version of AutoRest, as well as the commitid of your swagger spec or link to the swagger spec, used to generate the code. (Track 2 only)
The *.csproj and AssemblyInfo.cs files have been updated with the new version of the SDK. Please double check nuget.org current release version.

Additional management plane SDK specific contribution checklist:

Note: Only applies to Microsoft.Azure.Management.[RP] or Azure.ResourceManager.[RP]

Include updated management metadata.
Update AzureRP.props to add/remove version info to maintain up to date API versions.

Management plane SDK Troubleshooting

If this is very first SDK for a services and you are adding new service folders directly under /SDK, please add new service label and/or contact assigned reviewer.
If the check fails at the Verify Code Generation step, please ensure:
- Do not modify any code in generated folders.
- Do not selectively include/remove generated files in the PR.
- Do use generate.ps1/cmd to generate this PR instead of calling autorest directly.
  Please pay attention to the @microsoft.csharp version output after running generate.ps1. If it is lower than current released version (2.3.82), please run it again as it should pull down the latest version.
Note: We have recently updated the PSH module called by generate.ps1 to emit additional data. This would help reduce/eliminate the Code Verification check error. Please run following command:
```
  `dotnet msbuild eng/mgmt.proj /t:Util /p:UtilityName=InstallPsModules`
```

Old outstanding PR cleanup

Please note:
If PRs (including draft) has been out for more than 60 days and there are no responses from our query or followups, they will be closed to maintain a concise list for our reviewers.

…udio Feature.

check-enforcer · 2021-08-18T01:00:00Z

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them. In order to bootstrap pipelines for a new service, please perform following steps:

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run net - [service] - ci

For track 1 management-plane SDKs

Please open a separate PR and to your service SDK path in this file. Once that PR has been merged, you can re-run the pipeline to trigger the verification.

sdk/communication/Azure.Communication.CallingServer/src/CallingServerClientOptions.cs

sdk/communication/Azure.Communication.CallingServer/src/ServerCall.cs

minnieliu

Please also consider updating the README file so that users understand how to use this new change in the SDK.

minnieliu · 2021-08-25T00:07:48Z

/azp run net - Azure.Communication.CallingServer - tests

azure-pipelines · 2021-08-25T00:07:59Z

Azure Pipelines successfully started running 1 pipeline(s).

# Conflicts: # sdk/communication/Azure.Communication.CallingServer/tests/Infrastructure/CallingServerLiveTestBase.cs # sdk/communication/Azure.Communication.CallingServer/tests/SessionRecords/ServerCallLiveTests/RunAllRecordingFunctionsWithConnectionString.json # sdk/communication/Azure.Communication.CallingServer/tests/SessionRecords/ServerCallLiveTests/RunAllRecordingFunctionsWithConnectionStringAsync.json

minnieliu · 2021-08-26T19:32:29Z

/azp run net - Azure.Communication.CallingServer - tests

azure-pipelines · 2021-08-26T19:32:41Z

Azure Pipelines successfully started running 1 pipeline(s).

Mohit-Chakraborty · 2021-09-20T20:55:36Z

sdk/communication/Azure.Communication.CallingServer/src/CallingServerClientOptions.cs

+            V2021_06_15_Preview = 1,
+#pragma warning restore CA1707 // Identifiers should not contain underscores
+            /// <summary>
+            /// The Beta of the CallingServer service.


Better to have distinct comments for the 2 versions.
Something like 'The 2021_08_30 version of the CallingServer service.' And similarly for the one above.

Mohit-Chakraborty · 2021-09-20T20:56:56Z

sdk/communication/Azure.Communication.CallingServer/src/ServerCall.cs

-        public virtual async Task<Response<StartCallRecordingResult>> StartRecordingAsync(Uri recordingStateCallbackUri, CancellationToken cancellationToken = default)
+        /// <param name="recordingContentType">Contenttype for recording.</param>
+        /// <param name="recordingChannelType">Channeltype for recording.</param>
+        /// <param name="recordingFormatType">Channeltype for recording.</param>


Format type for recording.

Mohit-Chakraborty · 2021-09-20T20:57:09Z

sdk/communication/Azure.Communication.CallingServer/src/ServerCall.cs

-        public virtual Response<StartCallRecordingResult> StartRecording(Uri recordingStateCallbackUri, CancellationToken cancellationToken = default)
+        /// <param name="recordingContentType">Contenttype for recording.</param>
+        /// <param name="recordingChannelType">Channeltype for recording.</param>
+        /// <param name="recordingFormatType">Channeltype for recording.</param>


Format type for recording.

Mohit-Chakraborty · 2021-09-20T21:02:29Z

...on/Azure.Communication.CallingServer/api/Azure.Communication.CallingServer.netstandard2.0.cs

@@ -317,8 +373,8 @@ public partial class ServerCall
        public virtual System.Threading.Tasks.Task<Azure.Response> RemoveParticipantAsync(string participantId, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
        public virtual Azure.Response ResumeRecording(string recordingId, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
        public virtual System.Threading.Tasks.Task<Azure.Response> ResumeRecordingAsync(string recordingId, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
-        public virtual Azure.Response<Azure.Communication.CallingServer.StartCallRecordingResult> StartRecording(System.Uri recordingStateCallbackUri, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
-        public virtual System.Threading.Tasks.Task<Azure.Response<Azure.Communication.CallingServer.StartCallRecordingResult>> StartRecordingAsync(System.Uri recordingStateCallbackUri, System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }
+        public virtual Azure.Response<Azure.Communication.CallingServer.StartCallRecordingResult> StartRecording(System.Uri recordingStateCallbackUri, Azure.Communication.CallingServer.RecordingContentType? recordingContentType = default(Azure.Communication.CallingServer.RecordingContentType?), Azure.Communication.CallingServer.RecordingChannelType? recordingChannelType = default(Azure.Communication.CallingServer.RecordingChannelType?), Azure.Communication.CallingServer.RecordingFormatType? recordingFormatType = default(Azure.Communication.CallingServer.RecordingFormatType?), System.Threading.CancellationToken cancellationToken = default(System.Threading.CancellationToken)) { throw null; }


Should we remove the existing APIs or mark them as EditorBrowsableState.Never and change their impl to forward to the new methods.

Code for changes in models for StartRecordingCall Request for Mixed A…

3137c92

…udio Feature.

ghost added the Communication label Aug 17, 2021

ninikasharma changed the title ~~Code for changes in models for StartRecordingCall Request for Mixed A…~~ Changes in StartRecordingCall Request models for Mixed Audio Only Feature Aug 17, 2021

ninikasharma requested review from zihzhan-msft and navali-msft August 17, 2021 00:46

ninikasharma marked this pull request as draft August 17, 2021 19:44

ninsharm added 2 commits August 17, 2021 14:23

Updating the api version

1b911ee

Added feature details and ran eng\scripts\Export-API.ps1 script

52f8d03

ninikasharma requested review from arifsaikat-microsoft, minnieliu, chrwhit and cochi2 August 18, 2021 00:32

Merge branch 'main' into ninsharm/mixed_audio_models_change

e258ecb

arifsaikat-microsoft reviewed Aug 18, 2021

View reviewed changes

sdk/communication/Azure.Communication.CallingServer/src/CallingServerClientOptions.cs Show resolved Hide resolved

Added test cases, change Server Call Client

ee25dfb

minnieliu reviewed Aug 19, 2021

View reviewed changes

sdk/communication/Azure.Communication.CallingServer/src/ServerCall.cs Outdated Show resolved Hide resolved

minnieliu reviewed Aug 19, 2021

View reviewed changes

Addressed PR comments, Recorded Live tests

c6d0442

ninikasharma marked this pull request as ready for review August 24, 2021 23:45

ninikasharma requested review from KrzysztofCwalina and tg-msft as code owners August 24, 2021 23:45

minnieliu approved these changes Aug 25, 2021

View reviewed changes

ninsharm added 5 commits August 24, 2021 18:50

Ran the autogeneration scripts

f69c371

More live tests updated

7e528d6

Recorded more live tests

7d08703

Two more live test records updated

c06a99c

ninsharm added 2 commits August 26, 2021 11:04

Added some test recordings

e75c033

api version updated for test

e1ec3bd

minnieliu merged commit e336a5b into main Aug 26, 2021

minnieliu deleted the ninsharm/mixed_audio_models_change branch August 26, 2021 23:31

Mohit-Chakraborty reviewed Sep 20, 2021

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Changes in StartRecordingCall Request models for Mixed Audio Only Feature #23354

Changes in StartRecordingCall Request models for Mixed Audio Only Feature #23354

ninikasharma commented Aug 17, 2021 •

edited

Loading

check-enforcer bot commented Aug 18, 2021

minnieliu left a comment

minnieliu commented Aug 25, 2021

azure-pipelines bot commented Aug 25, 2021

minnieliu commented Aug 26, 2021

azure-pipelines bot commented Aug 26, 2021

Mohit-Chakraborty Sep 20, 2021

Mohit-Chakraborty Sep 20, 2021

Mohit-Chakraborty Sep 20, 2021

Mohit-Chakraborty Sep 20, 2021

Changes in StartRecordingCall Request models for Mixed Audio Only Feature #23354

Changes in StartRecordingCall Request models for Mixed Audio Only Feature #23354

Conversation

ninikasharma commented Aug 17, 2021 • edited Loading

All SDK Contribution checklist:

General Guidelines and Best Practices

Testing Guidelines

SDK Generation Guidelines

Additional management plane SDK specific contribution checklist:

Management plane SDK Troubleshooting

Old outstanding PR cleanup

check-enforcer bot commented Aug 18, 2021

What is Check Enforcer?

Why am I getting this message?

What should I do now?

What if I am onboarding a new service?

For data-plane/track 2 SDKs Issue the following command as a pull request comment:

For track 1 management-plane SDKs

minnieliu left a comment

Choose a reason for hiding this comment

minnieliu commented Aug 25, 2021

azure-pipelines bot commented Aug 25, 2021

minnieliu commented Aug 26, 2021

azure-pipelines bot commented Aug 26, 2021

Mohit-Chakraborty Sep 20, 2021

Choose a reason for hiding this comment

Mohit-Chakraborty Sep 20, 2021

Choose a reason for hiding this comment

Mohit-Chakraborty Sep 20, 2021

Choose a reason for hiding this comment

Mohit-Chakraborty Sep 20, 2021

Choose a reason for hiding this comment

ninikasharma commented Aug 17, 2021 •

edited

Loading