Sync eng/common directory with azure-sdk-tools for PR 1374 (#16764)

* Create package property file using artifact name * Add option to pass config file dir * Set default config file directory to avoid script execution failure Co-authored-by: praveenkuttappan <prmarott@microsoft.com>
Azure · Feb 16, 2021 · 5e94c0e · 5e94c0e
1 parent 3d0ae19
commit 5e94c0e
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/eng/common/pipelines/templates/steps/create-apireview.yml b/eng/common/pipelines/templates/steps/create-apireview.yml
@@ -1,6 +1,7 @@
 parameters:
   ArtifactPath: $(Build.ArtifactStagingDirectory)
   Artifacts: []
+  ConfigFileDir: $(Build.ArtifactStagingDirectory)/PackageInfo
 
 steps:
   - ${{ each artifact in parameters.Artifacts }}:
@@ -13,6 +14,7 @@ steps:
           -APIKey $(azuresdk-apiview-apikey)
           -APILabel "Auto Review - $(Build.SourceVersion)"
           -PackageName ${{artifact.name}}
+          -ConfigFileDir '${{parameters.ConfigFileDir}}'
         pwsh: true
         workingDirectory: $(Pipeline.Workspace)
       displayName: Create API Review for ${{ artifact.name}}

diff --git a/eng/common/scripts/Package-Properties.ps1 b/eng/common/scripts/Package-Properties.ps1
@@ -12,6 +12,7 @@ class PackageProps
     [string]$Group
     [string]$SdkType
     [boolean]$IsNewSdk
+    [string]$ArtifactName
 
     PackageProps([string]$name, [string]$version, [string]$directoryPath, [string]$serviceDirectory)
     {

diff --git a/eng/common/scripts/Save-Package-Properties.ps1 b/eng/common/scripts/Save-Package-Properties.ps1
@@ -10,15 +10,24 @@ Param (
 $allPackageProperties = Get-AllPkgProperties $serviceDirectory
 if ($allPackageProperties)
 {
-    New-Item -ItemType Directory -Force -Path $outDirectory
+    if (-not (Test-Path -Path $outDirectory))
+    {
+      New-Item -ItemType Directory -Force -Path $outDirectory
+    }
     foreach($pkg in $allPackageProperties)
     {
         if ($pkg.IsNewSdk)
         {
             Write-Host "Package Name: $($pkg.Name)"
             Write-Host "Package Version: $($pkg.Version)"
             Write-Host "Package SDK Type: $($pkg.SdkType)"
-            $outputPath = Join-Path -Path $outDirectory ($pkg.Name + ".json")
+            Write-Host "Artifact Name: $($pkg.ArtifactName)"
+            $configFilePrefix = $pkg.Name
+            if ($pkg.ArtifactName)
+            {
+              $configFilePrefix = $pkg.ArtifactName
+            }
+            $outputPath = Join-Path -Path $outDirectory "$configFilePrefix.json"
             $outputObject = $pkg | ConvertTo-Json
             Set-Content -Path $outputPath -Value $outputObject
         }        
@@ -31,4 +40,3 @@ else
     Write-Error "Package properties are not available for service directory $($serviceDirectory)"
     exit 1
 }
-