Skip to content

Commit

Permalink
Sync eng/common directory with azure-sdk-tools for PR 2016 (#20706)
Browse files Browse the repository at this point in the history
* Make ServiceName optional for verify-changelog

In cases like go where we don't pass a service name having this default to "not-specified" breaks things so we should allow for ServiceName and/or ServiceDirectory to be empty.

* Put quotes around the strings to allow for empty

Co-authored-by: Wes Haggard <weshaggard@users.noreply.github.com>
  • Loading branch information
azure-sdk and weshaggard committed Sep 15, 2021
1 parent c80e26e commit 87e0f99
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions eng/common/pipelines/templates/steps/verify-changelog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ parameters:
default: 'not-specified'
- name: ServiceName
type: string
default: 'not-specified'
default: ''
- name: ServiceDirectory
type: string
default: ''
Expand All @@ -17,10 +17,10 @@ steps:
inputs:
filePath: $(Build.SourcesDirectory)/eng/common/scripts/Verify-ChangeLog.ps1
arguments: >
-PackageName ${{ parameters.PackageName }}
-ServiceDirectory ${{ coalesce(parameters.ServiceDirectory, parameters.ServiceName) }}
-PackageName '${{ parameters.PackageName }}'
-ServiceDirectory '${{ coalesce(parameters.ServiceDirectory, parameters.ServiceName) }}'
-ForRelease $${{ parameters.ForRelease }}
pwsh: true
workingDirectory: $(Pipeline.Workspace)
displayName: Verify ChangeLogEntry for ${{ parameters.PackageName }}
continueOnError: false
continueOnError: false

0 comments on commit 87e0f99

Please sign in to comment.