Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ATOM API runtime vs. description properties, should any move from former to latter #12413

Closed
KieranBrantnerMagee opened this issue Jul 7, 2020 · 2 comments
Closed

ATOM API runtime vs. description properties, should any move from former to latter #12413

KieranBrantnerMagee opened this issue Jul 7, 2020 · 2 comments
Assignees
@KieranBrantnerMagee
Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Milestone
[2020] August

Comments

@KieranBrantnerMagee
Copy link
Member

Currently service bus mgmt APIs return two different entity-description blobs, runtime properties and description properties.

Align with broader SDK family on if these settings are divided properly, if needed proposal->architects etc.
@KieranBrantnerMagee KieranBrantnerMagee added Service Bus Client This issue points to a problem in the data-plane of the library. labels Jul 7, 2020
@KieranBrantnerMagee KieranBrantnerMagee added this to the [2020] August milestone Jul 7, 2020
@KieranBrantnerMagee KieranBrantnerMagee self-assigned this Jul 7, 2020
@ramya-rao-a
Copy link
Contributor

@KieranBrantnerMagee Can we close this if #12576 tracks the same but with more details?

@KieranBrantnerMagee
Copy link
Member Author

It's not QUITE the same, the issue you link had to do with the actual split itself, and the naming surrounding it, where this was questioning whether any of the internal properties should shuffle around.

For the purpose of cleaning up the board though I can encapsulate this question inside that issue though, it's not unreasonable.

@KieranBrantnerMagee KieranBrantnerMagee mentioned this issue Jul 21, 2020
Closed
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Jan 18, 2021
@sgchris @weidongxu-microsoft
CodeGen from PR 12413 in Azure/azure-rest-api-specs
0899c13 
Dev monitor microsoft.insights 2016 03 01 (Azure#12413)

* fixed lint - make provider pascal case

https://portal.azure-devex-tools.com/amekpis/linting/detail?errorId=00977335-6FD1-4DCF-8CD0-96F194252EED

* fixed default response

https://portal.azure-devex-tools.com/amekpis/linting/detail?errorId=3A0A2C18-E2AB-4671-B50E-A79865800B41

* added suppress info for R4007

* removed extra line

* change the place of a default

* added description to few default responses

* added suppression on additional properties

* added suppress on error schema

* Update readme.md

Co-authored-by: Gregory Chris <sgchris@gmail.com>
Co-authored-by: Weidong Xu <weidxu@microsoft.com>
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this issue Jan 18, 2021
@sgchris @weidongxu-microsoft
CodeGen from PR 12413 in Azure/azure-rest-api-specs
0b93da9 
Dev monitor microsoft.insights 2016 03 01 (Azure#12413)

* fixed lint - make provider pascal case

https://portal.azure-devex-tools.com/amekpis/linting/detail?errorId=00977335-6FD1-4DCF-8CD0-96F194252EED

* fixed default response

https://portal.azure-devex-tools.com/amekpis/linting/detail?errorId=3A0A2C18-E2AB-4671-B50E-A79865800B41

* added suppress info for R4007

* removed extra line

* change the place of a default

* added description to few default responses

* added suppression on additional properties

* added suppress on error schema

* Update readme.md

Co-authored-by: Gregory Chris <sgchris@gmail.com>
Co-authored-by: Weidong Xu <weidxu@microsoft.com>
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@KieranBrantnerMagee KieranBrantnerMagee

Labels
Client This issue points to a problem in the data-plane of the library. Service Bus
Projects
None yet
Milestone
[2020] August
Development

No branches or pull requests
2 participants
@ramya-rao-a @KieranBrantnerMagee