Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot Create EH compatible endpoint if IoT Hub name is more than 25 chars #19087

Closed
1 task done
swathipil opened this issue Jun 3, 2021 · 1 comment · Fixed by #19314
Closed
1 task done

Cannot Create EH compatible endpoint if IoT Hub name is more than 25 chars #19087

swathipil opened this issue Jun 3, 2021 · 1 comment · Fixed by #19314
Assignees
@swathipil
Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs IoT Messaging Messaging crew P0
Milestone
[2021] July

Comments

@swathipil
Copy link
Member

swathipil commented Jun 3, 2021 •
edited
Loading

IoT Hub Service is silently truncating the IoT Hub name in the Event Hub compatible endpoint to 25 characters. This is not documented anywhere.

This silent mutation of information passed in by the user should not be happening. Since this is a service issue, we have contacted the IoT team to let them know about the bug, so that they can either fix it or document it.

A PR was created to address this issue in EH: #18521
We decided not to accept the PR since it would also mean silently changing information passed in by the user.

TODO:

  • poke the service team again about this issue
@swathipil swathipil added Event Hubs IoT Client This issue points to a problem in the data-plane of the library. Messaging Messaging crew labels Jun 3, 2021
@swathipil swathipil added this to the [2021] July milestone Jun 3, 2021
@swathipil swathipil self-assigned this Jun 3, 2021
@swathipil swathipil mentioned this issue Jun 3, 2021
Closed
@yunhaoling yunhaoling added the P0 label Jun 14, 2021
This was referenced Jun 17, 2021
Closed
Merged
@swathipil
Copy link
Member Author

After discussion with Jesse + Sherry Shu, it was found that C# was no longer able to reproduce this error. In Python, realized that we need to get the IoT Hub name from the redirection address.

@ghost ghost closed this as completed in #19314 Jun 23, 2021
ghost pushed a commit that referenced this issue Jun 23, 2021
@swathipil
[EventHubs] Get IoT Hub Name from Redirect Address in sample (#19314)
074f36d 
Fixes: #19087 
Follows[ C# sample,](https://github.com/Azure/azure-sdk-for-net/blob/350c23ea19ed76d74f7d97dfe3aec82671fdcc9d/samples/iothub-connect-to-eventhubs/IotHubConnection.cs#L97) which also gets IoT Hub name from redirect address.
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this issue Jul 16, 2021
@swathipil @rakshith91
[EventHubs] Get IoT Hub Name from Redirect Address in sample (Azure#1…
390da8e 
…9314)

Fixes: Azure#19087 
Follows[ C# sample,](https://github.com/Azure/azure-sdk-for-net/blob/350c23ea19ed76d74f7d97dfe3aec82671fdcc9d/samples/iothub-connect-to-eventhubs/IotHubConnection.cs#L97) which also gets IoT Hub name from redirect address.
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
This issue was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@swathipil swathipil

Labels
Client This issue points to a problem in the data-plane of the library. Event Hubs IoT Messaging Messaging crew P0
Projects
None yet
Milestone
[2021] July
2 participants
@yunhaoling @swathipil