Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

edit all authentication files and add a test #13355

Merged
merged 3 commits into from
Aug 28, 2020
Merged

edit all authentication files and add a test #13355

merged 3 commits into from
Aug 28, 2020

Conversation

xiafu-msft
Copy link
Contributor

@xiafu-msft xiafu-msft commented Aug 27, 2020 •
edited
Loading

@ghost ghost added the Storage Storage Service (Queues, Blobs, Files) label Aug 27, 2020
tasherif-msft
tasherif-msft previously approved these changes Aug 27, 2020
View reviewed changes
Copy link
Contributor

@tasherif-msft tasherif-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@xiafu-msft
Copy link
Contributor Author

/azp run python - storage

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@xiafu-msft xiafu-msft merged commit 077e344 into Azure:master Aug 28, 2020
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Sep 1, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
05be0b7 
…into expose_parse_vault_id

* 'master' of https://github.com/Azure/azure-sdk-for-python: (37 commits)
  [text analytics] add versionadded sphinx documentation (Azure#13450)
  [text analytics] add bing_id property to LinkedEntity class (Azure#13446)
  fix typing for paging methods (Azure#13410)
  [text analytics] add domain_filter param (Azure#13451)
  fix issue Azure#11658 for is_valid_resource_id (Azure#11709)
  added create_table_if_not_exists method to table service client (Azure#13385)
  [ServiceBus] Test and failure improvements (Azure#13345)
  Proper encoding and decoding of source URLs - Fixes special characters in source URL issue (Azure#13275)
  Switch retry (Azure#13264)
  [ServiceBus] ServiceBusClient close spawned children (Azure#13077)
  fixing version issue by not overwriting the version with the semantic… (Azure#13411)
  clean up reference and tests (Azure#13412)
  Consistent returns (Azure#13245)
  [text analytics] return None for offset and length for v3.0 (Azure#13382)
  edit all authentication files and add a test (Azure#13355)
  Add managed_identity_client_id argument to DefaultAzureCredential (Azure#13218)
  [text analytics] add string-index-type support (Azure#13378)
  [text analytics] fix error response if pii entities is called from v3.0 client (Azure#13383)
  Send spec (Azure#13143)
  Anomaly Detector 3.0.0b2 release (Azure#13351)
  ...
@xiafu-msft xiafu-msft mentioned this pull request Sep 1, 2020
Closed
@aviramha
Copy link
Contributor

aviramha commented Sep 1, 2020

I was removed as an author 😢

@xiafu-msft
Copy link
Contributor Author

xiafu-msft commented Sep 1, 2020 •
edited
Loading

@aviramha sorry that I should have gave you a heads up that I didn't merge your pr, and thanks for the commit!
I didn't merge your PR because at that time the CI in your PR failed #13346, and I wasn't sure what caused the failure, plus I added a commit 3912ea6 to your PR and I was worried my change broke the CI, so I created a new PR to play around with. (If I use your PR to play around you will get a lot of notifications)
Finally it turned out CI failure was caused by the changes in our dependency, and the CI failure was blocking other people's pr, so once I got the approval I didn't think too much and merged the fix along with the copied commit.

@aviramha
Copy link
Contributor

aviramha commented Sep 2, 2020

Hmm it's a bit tricky but you could rebase and amend author for the commit
https://stackoverflow.com/questions/3042437/how-to-change-the-commit-author-for-one-specific-commit

@xiafu-msft
Copy link
Contributor Author

xiafu-msft commented Sep 2, 2020 •
edited
Loading

@aviramha I've partially reverted the commit and merged it to master this afternoon #13501.
You can rebase against master and we will merge your pr later

@aviramha
Copy link
Contributor

aviramha commented Sep 2, 2020

@xiafu-msft Thanks, I really appreciate it. Sorry for being "annoying" :)

@xiafu-msft
Copy link
Contributor Author

@aviramha for sure. Not at all, I should have noticed that, thanks for your understanding!

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Mar 23, 2021
CodeGen from PR 13355 in Azure/azure-rest-api-specs
5dbaeec 
[Management Plane][Azure Search] Adding new API version 2021-01-04. (Azure#13355)

* [Management Plane][Azure Search] Adding new API version for exposing Encryption with CMK.

* Fixing prittier and model validation errors

* Fixing errors raised by lintdiff and ModelValidations
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Mar 24, 2021
CodeGen from PR 13595 in Azure/azure-rest-api-specs
ad9da71 
Revert "[Management Plane][Azure Search] Adding new API version 2021-01-04. (Azure#13355)" (Azure#13595)

This reverts commit 5c2185a.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rakshith91 rakshith91 rakshith91 approved these changes

@tasherif-msft tasherif-msft tasherif-msft left review comments

@amishra-dev amishra-dev Awaiting requested review from amishra-dev

@annatisch annatisch Awaiting requested review from annatisch

@kasobol-msft kasobol-msft Awaiting requested review from kasobol-msft

@zezha-msft zezha-msft Awaiting requested review from zezha-msft

Assignees
No one assigned
Labels
Storage Storage Service (Queues, Blobs, Files)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xiafu-msft @aviramha @rakshith91 @tasherif-msft