Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align azure-keyvault-administration API with other SDKs #15717

Merged
merged 9 commits into from
Dec 11, 2020

Conversation

chlowell
Copy link
Member

@chlowell chlowell commented Dec 8, 2020

This renames that which needs renaming to align with our equivalent libraries in other languages. Also fixes a bug in parsing backup folder URLs that was discovered during our alignment review.

@chlowell chlowell added KeyVault Client This issue points to a problem in the data-plane of the library. labels Dec 8, 2020
mccoyp
mccoyp previously approved these changes Dec 9, 2020
Copy link
Member

@mccoyp mccoyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

heaths
heaths previously approved these changes Dec 9, 2020
Copy link
Member

@heaths heaths left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks right, but might want to have @christothes take a look as well.

vcolin7
vcolin7 previously approved these changes Dec 9, 2020
Copy link
Member

@vcolin7 vcolin7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@chlowell chlowell dismissed stale reviews from vcolin7, heaths, and mccoyp via 9a6525e December 9, 2020 21:07
@chlowell chlowell merged commit 2dd1409 into Azure:master Dec 11, 2020
@chlowell chlowell deleted the admin-renaming branch December 11, 2020 16:28
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Dec 14, 2020
…into new_polling

* 'master' of https://github.com/Azure/azure-sdk-for-python: (223 commits)
  generate mixedreality track2 sdk (Azure#15779)
  Fix mypy in core authentication (Azure#15768)
  [Media] Added new LVA Edge SDK (Azure#15375)
  Sync eng/common directory with azure-sdk-tools for PR 1273 (Azure#15767)
  Sync eng/common directory with azure-sdk-tools for PR 1274 (Azure#15765)
  Sync eng/common directory with azure-sdk-tools for PR 1270 (Azure#15766)
  [Media] Add nspkg package  (Azure#15751)
  Update readme example to import async client (Azure#15763)
  Align azure-keyvault-administration API with other SDKs (Azure#15717)
  Create Initial cut at an early preview (machine generated) version of python SDK. (Azure#15712)
  Add additional code owner for Azure Communication Services (Azure#15738)
  Increment version for storage releases (Azure#15690)
  Create PR to target against master (Azure#15748)
  Fix dependence (Azure#15746)
  [T2]kubernetesconfiguration (Azure#15726)
  [T2] redhatopenshift (Azure#15743)
  [T2]hybridkubernetes (Azure#15725)
  generate servicefabric track2 version (Azure#15601)
  generate synapse track2 sdk (Azure#15745)
  generate serialconsole track2 sdk (Azure#15744)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Client This issue points to a problem in the data-plane of the library. KeyVault
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants