Metrics advisor aad #15922
Merged
Metrics advisor aad #15922
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
...or/azure-ai-metricsadvisor/azure/ai/metricsadvisor/_metrics_advisor_administration_client.py
Outdated
Show resolved
Hide resolved
...or/azure-ai-metricsadvisor/azure/ai/metricsadvisor/_metrics_advisor_administration_client.py
Outdated
Show resolved
Hide resolved
...or/azure-ai-metricsadvisor/azure/ai/metricsadvisor/_metrics_advisor_administration_client.py
Outdated
Show resolved
Hide resolved
sdk/metricsadvisor/azure-ai-metricsadvisor/samples/async_samples/sample_authentication_async.py
Show resolved
Hide resolved
sdk/metricsadvisor/azure-ai-metricsadvisor/samples/async_samples/sample_authentication_async.py
Show resolved
Hide resolved
sdk/metricsadvisor/azure-ai-metricsadvisor/tests/test_metrics_advisor_client_live.py
Outdated
Show resolved
Hide resolved
…isor/_metrics_advisor_administration_client.py Co-authored-by: Krista Pratico <krpratic@microsoft.com>
…isor/_metrics_advisor_administration_client.py Co-authored-by: Krista Pratico <krpratic@microsoft.com>
|
@xiangyan99 i see 368 files changed in this PR - did the rebase go bad? |
No. This is by design. We have hundreds of tests. :) You can ignore all files ending with .yaml. They are test recordings. |
| @@ -59,7 +60,8 @@ class MetricsAdvisorClient(object): | |||
| :param str endpoint: Supported Cognitive Services endpoints (protocol and hostname, | |||
| for example: https://:code:`<resource-name>`.cognitiveservices.azure.com). | |||
| :param credential: An instance of ~azure.ai.metricsadvisor.MetricsAdvisorKeyCredential. | |||
| Requires both subscription key and API key. | |||
| which requires both subscription key and API key. Or an object which can provide an access | |||
| token for the vault, such as a credential from :mod:`azure.identity` | |||
There was a problem hiding this comment.
Can we update the credential docstring for the other clients as well?
kristapratico
approved these changes
Jan 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.