Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

renamed checkpoint by batch samples to by event count #15977

Merged
merged 2 commits into from
Jan 5, 2021
Merged

renamed checkpoint by batch samples to by event count #15977

merged 2 commits into from
Jan 5, 2021

Conversation

swathipil
Copy link
Member

addressing: #15114

@ghost ghost added the Event Hubs label Jan 4, 2021
@swathipil swathipil requested review from rakshith91 and removed request for annatisch and KieranBrantnerMagee January 4, 2021 22:45
@swathipil swathipil mentioned this pull request Jan 4, 2021
Closed
@yunhaoling
Copy link
Contributor

hey @swathipil , as the CI is complaining:

Found 38 links on page file:///home/vsts/work/1/s/sdk/eventhub/azure-eventhub/samples/README.md
##[warning][404] broken link ***/tree/868109d1dd3844168cceedaaa846e5ef0b912b2b/sdk/eventhub/azure-eventhub/samples/async_samples/recv_with_checkpoint_by_batch_async.py
##[warning][404] broken link ***/tree/868109d1dd3844168cceedaaa846e5ef0b912b2b/sdk/eventhub/azure-eventhub/samples/sync_samples/recv_with_checkpoint_by_batch.py
Summary of broken links:
'file:///home/vsts/work/1/s/sdk/eventhub/azure-eventhub/samples/README.md' has 2 broken link(s):
  ***/tree/master/sdk/eventhub/azure-eventhub/samples/async_samples/recv_with_checkpoint_by_batch_async.py
  ***/tree/master/sdk/eventhub/azure-eventhub/samples/sync_samples/recv_with_checkpoint_by_batch.py

we need to update the samples/readme.md to reflect the changes of the two files

@swathipil swathipil merged commit a6e0a61 into Azure:master Jan 5, 2021
@swathipil swathipil deleted the swathipil/eh/fix-sample-name branch January 5, 2021 02:20
rakshith91 pushed a commit to rakshith91/azure-sdk-for-python that referenced this pull request Jan 8, 2021
@swathipil @rakshith91
renamed checkpoint by batch samples to by event count (Azure#15977)
50e6bef 
* renamed checkpoint by batch samples to by event count

* change link in EH sample readme for event count sample
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jan 8, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
184e235 
…into new_polling

* 'master' of https://github.com/Azure/azure-sdk-for-python: (85 commits)
  Update to Update-Changelog.ps1 (Azure#15981)
  Fix put_encrypted_blob function (Azure#15918)
  renamed checkpoint by batch samples to by event count (Azure#15977)
  Migration guide for EventGrid (Azure#15731)
  Clearer message for incomplete environment configuration (Azure#15974)
  renamed async checkpoint sample readme title (Azure#15958)
  fixed 'async with outside async func' syntax error in EH async auth with conn str sample (Azure#15955)
  fixed typo in EH sample + readme (Azure#15954)
  Clean up batch delete sample (Azure#15898)
  Add azure core to mgmt dependency (Azure#15969)
  [T2] GA rdbms (Azure#15934)
  GA commerce track2 sdk (Azure#15907)
  GA batch track2 sdk (Azure#15906)
  GA policyinsights track2 sdk (Azure#15905)
  GA search track2 sdk (Azure#15904)
  GA notificationhubs track2 sdk (Azure#15903)
  [T2] GA relay (Azure#15902)
  GA cognitiveservices track2 sdk (Azure#15901)
  GA advisor track2 sdk (Azure#15900)
  GA marketplaceordering track2 sdk (Azure#15899)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yunhaoling yunhaoling yunhaoling approved these changes

@rakshith91 rakshith91 Awaiting requested review from rakshith91

Assignees
No one assigned
Labels
Event Hubs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swathipil @yunhaoling