Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Event Hubs] created EventHubConnectionStringProperties and connection string parser #16204

Merged
merged 6 commits into from
Jan 26, 2021

Conversation

swathipil
Copy link
Member

@swathipil swathipil commented Jan 15, 2021

addressing: #14575
following the SB Connection String parser: #14574

@swathipil
Copy link
Member Author

swathipil commented Jan 15, 2021

/azp run python - eventhub - tests

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@rakshith91 rakshith91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - make sure @yunhaoling signs it off too before you merge it :)

@swathipil
Copy link
Member Author

/azp run python - eventhub - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil
Copy link
Member Author

/azp run python - eventhub - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Co-authored-by: Adam Ling (MSFT) <adam_ling@outlook.com>
Copy link
Contributor

@yunhaoling yunhaoling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@annatisch annatisch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just to clarify - this isn't replacing the from_connection_string classmethods is it? Just supplementary?

@swathipil
Copy link
Member Author

@annatisch nope! It's just supplementary, to "assist with transforming a connection string for use with credential-based client creation".

@swathipil
Copy link
Member Author

/azp run python - eventhub - tests

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@swathipil swathipil enabled auto-merge (squash) January 25, 2021 21:13
@swathipil swathipil merged commit 2b68dcd into Azure:master Jan 26, 2021
@swathipil swathipil deleted the swathipil/eh/conn-str-parser branch January 26, 2021 18:06
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants