Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Communication] - Extract Identity Package out of Administration Package #16300

Merged
merged 43 commits into from
Jan 26, 2021

Conversation

lsundaralingam
Copy link
Member

No description provided.

beltr0n and others added 30 commits January 21, 2021 15:35
initial commit: new folder for identity
…onal

Added root files to identity package
…sonal

Removed identity tests from admin package
…sonal

Removed user credential test in admin package
@check-enforcer
Copy link

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

@lsundaralingam
Copy link
Member Author

/azp run python - communication - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lsundaralingam lsundaralingam marked this pull request as ready for review January 23, 2021 00:52
@lsundaralingam lsundaralingam changed the title Communication - Extract Identity Package out of Administration Package [Communication] - Extract Identity Package out of Administration Package Jan 25, 2021
@@ -3,6 +3,7 @@
## 1.0.0b4 (Unreleased)

### Breaking Changes
- CommunicationIdentityClient is moved to a new package: "azure.communication.identity"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we also need this package to be added to the ci.yml file for letting this run in the pipeline too. But it make sense to have another PR for this part.

Copy link
Member Author

@lsundaralingam lsundaralingam Jan 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added the identity package to the ci.yml file.

@turalf turalf merged commit 223d948 into Azure:master Jan 26, 2021
@lsundaralingam lsundaralingam deleted the communication-identity branch February 1, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants