converge management documentation generation to the same methodology … #16369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in preperation for deleting generate_doc.py
|
Thanks for taking the step! We can completely remove the |
|
@sima-zhu yep. That's right. |
|
@nickzhums, could you check the difference for the document? |
|
@jsntcy Nope other than that you folks ack that:
👍 |
scbedd
requested review from
danieljurek,
mitchdenny and
weshaggard
as code owners
|
@nickzhums once you sign off on this, I'll merge it. Waiting to merge till you do 👍 |
nickzhums
approved these changes
Feb 3, 2021
approved, thanks! |
|
Thank you! Not going to merge this today as it does touch code that gets used in release. Next week sometime. Thanks! |
scbedd
added a commit
to scbedd/azure-sdk-for-python
that referenced
this pull request
Mar 11, 2021
…e#16363)" Revert "converge management documentation generation to the same methodology … (Azure#16369)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…in preparation for deleting generate_doc.py
Hey @changlong-liu this is out of the blue, but @sima-zhu tagged me on another PR that prompted me to start this process.
When you get a few minutes, can you please take a look at this PR? It has some changes of substance for what you see on github.io, but nothing gamebreaking.
You don't need to worry about getting a direct comparison, I've gotten that done for you already!
For acceptance, please compare the results of a
sphinxrun ofazure-mgmt-storage.Grab these two artifacts:
And compare them.
Really the main difference is how the ToC is generated.