[text analytics] Updated tests failing in live mode #16795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
iscai-msft
reviewed
Feb 18, 2021
| @@ -294,7 +303,7 @@ async def test_out_of_order_ids(self, client): | |||
| self.assertEqual(resp.id, expected_order[idx]) | |||
|
|
|||
| @GlobalTextAnalyticsAccountPreparer() | |||
| @TextAnalyticsClientPreparer() | |||
| @TextAnalyticsClientPreparer(client_kwargs={"text_analytics_account_key": os.environ.get("AZURE_TEXT_ANALYTICS_KEY"), "text_analytics_account": os.environ.get("AZURE_TEXT_ANALYTICS_ENDPOINT")}) | |||
There was a problem hiding this comment.
hey @abhahn can you get rid of these environ variables in the future? i'm going to just push to this branch, but I think you adding this means your tests aren't fully set up correctly, can hop on a call today to figure this out more.
There was a problem hiding this comment.
Hey, looks like you did this already. I have had some issues getting the tests to run correctly in WSL, so it might help for us to review what I'm doing to see if there's something wrong.
iscai-msft
approved these changes
Feb 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used this log as a guide for which fixes to make.
I was able to reproduce all of the failures except for
test_analyze.test_all_successful_passing_string_pii_entities_taskwhich is still passing for me when running in live mode locally, so more investigation may be needed to determine why it's failing.