Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[translation] initial library #16837

Merged
merged 8 commits into from
Mar 4, 2021
Merged

[translation] initial library #16837

merged 8 commits into from
Mar 4, 2021

Conversation

kristapratico
Copy link
Member

@kristapratico kristapratico commented Feb 20, 2021 •
edited
Loading

This PR adds the most updated generated code and a thin convenience layer /skeleton for the client and models.

APIView: https://apiview.dev/Assemblies/Review/019355482c6245a5a404eef64740da1e

@kristapratico kristapratico self-assigned this Feb 20, 2021
Mohamed Shaban and others added 2 commits March 3, 2021 08:42
samples hero scenarios (#16936)
28aabfb 
* [samples] added 'batch_translation_async' sample

* [samples] added 'batch_translation_with_storage_async' sample

* [samples] added remianing async samples

* [samples] update file names

* [samples] added self to instance methods

* [samples][async] fix import textanalytics :)

* [samples] fix self. when calling instance methods

* [samples] fixed async check status to use AsyncItemPaged used in Async Client

* [samples] async -> some async operations instead of sync ones

* [samples][async] use async blob operations

* [samples][async] blob download async

* [samples][async] check_documents async

* [samples][async] added some missing await methods

* [async samples] change await time to recommended period

* [samples] updated async samples to comply with new changes
@kristapratico
remove 3.5 support
4501d16
@kristapratico kristapratico marked this pull request as ready for review March 3, 2021 17:02
@kristapratico kristapratico requested review from maririos and removed request for mitchdenny, lmazuel, danieljurek and mayurid March 3, 2021 17:02
maririos
maririos approved these changes Mar 4, 2021
View reviewed changes
Copy link
Member

@maririos maririos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only clarifying comment is pipeline and running samples

sdk/documenttranslation/azure-ai-documenttranslation/CHANGELOG.md
@@ -0,0 +1,3 @@
# Release History

## 1.0.0b1 (Unreleased)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh hello!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋

sdk/documenttranslation/azure-ai-documenttranslation/CHANGELOG.md
@@ -0,0 +1,3 @@
# Release History
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does the folder need to match the namespace? just wondering if this should be in translation or something else.
For now it is fine

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still part of the larger namespace issue. Might move around later.

sdk/documenttranslation/azure-ai-documenttranslation/azure/ai/documenttranslation/_client.py
)

@distributed_trace
def create_translation_job(self, batch, **kwargs):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty skeleton :P

sdk/documenttranslation/azure-ai-documenttranslation/setup.py
long_description=long_description,
url='https://github.com/Azure/azure-sdk-for-python',
author='Microsoft Corporation',
author_email='azuresdkengsysadmins@microsoft.com',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't know this was a thing

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was just copied straight from our template package

sdk/documenttranslation/tests.yml
trigger: none

jobs:
- template: ../../eng/pipelines/templates/jobs/archetype-sdk-tests.yml
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this add a pipeline for nightly test? will the samples start running?
I just wonder how the cleanup of the target container will work

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, only the ci pipeline will be created for recorded tests. We still need to figure out how we'll do creation/tear down of live resources. I'm going to look into that today a bit.

@kristapratico kristapratico merged commit 2b72fd0 into master Mar 4, 2021
@kristapratico kristapratico deleted the document-translation branch March 4, 2021 21:32
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Mar 5, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
f297542 
…into assertions

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  [core] add HttpRequest and HttpResponse reprs (Azure#16972)
  [text analytics] add actual normalized_text tests (Azure#17123)
  update samples to use actual role names (Azure#17124)
  Sync eng/common directory with azure-sdk-tools for PR 1448 (Azure#17085)
  Enable APIView status check (Azure#17107)
  Fix PackageName typo (Azure#17109)
  Move SetTestPipelineVersion.ps1 to eng/common (Azure#17103)
  Fix paths for non-windows agents (Azure#17096)
  [Communication] - Identity - Update README (Azure#17091)
  Rename CertificateCredential's certificate_bytes -> certificate_data (Azure#17090)
  fix shared reqs (Azure#17095)
  [translation] initial library (Azure#16837)
  EG - more docs imrpovement (Azure#17079)
  [EventHubs] add logging.info to warn the usage of partition key of non-string type (Azure#17057)
  march release (Azure#16966)
  Release of Device Update for IoT Hub SDK for Python. (Azure#17005)
  Add Get-AllPackageInfoFromRepo (Azure#16947)
  Track1 package is incorrectly set as track2 (Azure#17075)
iscai-msft added a commit to abhahn/azure-sdk-for-python that referenced this pull request Mar 5, 2021
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
a49dd8e 
…into ta-v5.1.0b6-analyze

* 'master' of https://github.com/Azure/azure-sdk-for-python: (24 commits)
  [text analytics] PII updates for v5.1.0b6 (Azure#17038)
  Fix bug where imported matrix parameter duplicates are not overrided (Azure#17126)
  Add NULL to readme (Azure#17076)
  Sas batching (Azure#17133)
  dropping py3.5 (Azure#17127)
  [EventHubs] 5.3.1 update changelog (Azure#17132)
  [text analytics] assertions (Azure#17098)
  add recordings (Azure#17125)
  [core] add HttpRequest and HttpResponse reprs (Azure#16972)
  [text analytics] add actual normalized_text tests (Azure#17123)
  update samples to use actual role names (Azure#17124)
  Sync eng/common directory with azure-sdk-tools for PR 1448 (Azure#17085)
  Enable APIView status check (Azure#17107)
  Fix PackageName typo (Azure#17109)
  Move SetTestPipelineVersion.ps1 to eng/common (Azure#17103)
  Fix paths for non-windows agents (Azure#17096)
  [Communication] - Identity - Update README (Azure#17091)
  Rename CertificateCredential's certificate_bytes -> certificate_data (Azure#17090)
  fix shared reqs (Azure#17095)
  [translation] initial library (Azure#16837)
  ...
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Nov 23, 2021
@msyyc
CodeGen from PR 16837 in Azure/azure-rest-api-specs
e19a78c 
containerservice-multiapi-config (Azure#16837)

* update

* Update readme.python.md

* Update readme.md

Co-authored-by: Yuchao Yan <yuchaoyan@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maririos maririos maririos approved these changes

Assignees

@mshaban-msft mshaban-msft

@kristapratico kristapratico

Labels
Cognitive - Translator
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kristapratico @maririos @mshaban-msft