add custom policy #17340
Merged
add custom policy #17340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Let's align with the other languages on this. Both .NET/C# and Java uses the perCall or perRetry terminology rather than first and last. I have not checked the javascript implementation. |
johanste
reviewed
Mar 18, 2021
johanste
reviewed
Mar 18, 2021
|
/azp run python - formrecognizer |
|
Azure Pipelines successfully started running 1 pipeline(s). |
annatisch
reviewed
Mar 24, 2021
annatisch
approved these changes
Mar 25, 2021
4 tasks
jiasli
reviewed
Apr 23, 2021
Comment on lines
+125
to
+127
| if isinstance(per_call_policies, Iterable): | ||
| for policy in per_call_policies: | ||
| policies.append(policy) |
There was a problem hiding this comment.
No need to explicitly iterate over per_call_policies. list.extend(iterable) does the same thing.
jiasli
reviewed
Apr 23, 2021
Comment on lines
+131
to
+134
| policies = policies + [config.redirect_policy, | ||
| config.retry_policy, | ||
| config.authentication_policy, | ||
| config.custom_hook_policy] |
There was a problem hiding this comment.
This causes a new list object to be created and assigned to policies. list.extend(iterable) is a better choice as it modifies policies directly.
Merged
|
Fix #16519: Support adding custom policy with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.