[Cosmos] Remove support for Python27, set Python36 as minimum, and update cosmos emulator pipeline #22475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simorenoh
requested review from
benbp,
kushagraThapar,
moderakh,
simplynaveen20,
weshaggard and
xinlian12
as code owners
ghost
added
the
11 tasks
…imorenoh/azure-sdk-for-python into cosmos-remove-python-2-support
annatisch
reviewed
Jan 12, 2022
| -e ../../../tools/azure-devtools | ||
| python_version >= '3.6' |
There was a problem hiding this comment.
Don't think we need this line
| name=name, verbose=verbose) | ||
| else: | ||
| super().__init__() | ||
| super().__init__() |
There was a problem hiding this comment.
hmm I wonder why the previous py2 code was passing in keyword params and the py3 code doesn't?
There was a problem hiding this comment.
not too sure to be honest, doesn't seem like they were even being set anywhere within the test
sdk/cosmos/azure-cosmos/setup.py
Outdated
| with open("README.md", encoding="utf-8") as f: | ||
| readme = f.read() | ||
| with open("CHANGELOG.md", encoding="utf-8") as f: | ||
| changelog = f.read() | ||
|
|
||
| exclude_packages = [ | ||
| "tests", | ||
| "tests.*", |
There was a problem hiding this comment.
What did we need this one for?
There was a problem hiding this comment.
good catch, it's also the wrong name for cosmos - we have tests as test for whatever reason, ill update
|
/azp run python - cosmos - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
annatisch
approved these changes
Jan 13, 2022
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jan 14, 2022
…into merge_patch * 'main' of https://github.com/Azure/azure-sdk-for-python: (72 commits) [tool]update llc-quick-start-tool for py3 only (Azure#22507) [mgmt] update setupy for python3.6 (Azure#22505) [pipeline] Upgrade python version to `python3.8` (Azure#22503) [AutoRelease] t2-synapse-2022-01-11-70733 (Azure#22439) Update tests.md (Azure#22500) disable per Azure#22498 (Azure#22499) [AnomalyDetector] Release 3.0.0b4 (Azure#22191) [translation] update docs to include managed identity option (Azure#22366) add back py3.6 (Azure#22478) Add Python 3.6 support back to Storage packages (Azure#22483) allow Python 3.6 with the sdk (Azure#22456) remove hardcoded subscription ID (Azure#22481) clean up tests/docs (Azure#22480) Increment version for eventhub releases (Azure#22485) [Cosmos] Remove support for Python27, set Python36 as minimum, and update cosmos emulator pipeline (Azure#22475) Increment version for servicebus releases (Azure#22484) add back py3.6 (Azure#22477) [AutoRelease] t2-datafactory-2022-01-06-31864 (Azure#22362) [AutoRelease] t2-apimanagement-2022-01-06-51326 (Azure#22361) [AutoRelease] t2-netapp-2022-01-12-75881 (Azure#22467) ...
|
LGTM, thanks for updating this @simorenoh! |
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jan 18, 2022
…into add_back_error_message * 'main' of https://github.com/Azure/azure-sdk-for-python: (127 commits) [tool]update llc-quick-start-tool for py3 only (Azure#22507) [mgmt] update setupy for python3.6 (Azure#22505) [pipeline] Upgrade python version to `python3.8` (Azure#22503) [AutoRelease] t2-synapse-2022-01-11-70733 (Azure#22439) Update tests.md (Azure#22500) disable per Azure#22498 (Azure#22499) [AnomalyDetector] Release 3.0.0b4 (Azure#22191) [translation] update docs to include managed identity option (Azure#22366) add back py3.6 (Azure#22478) Add Python 3.6 support back to Storage packages (Azure#22483) allow Python 3.6 with the sdk (Azure#22456) remove hardcoded subscription ID (Azure#22481) clean up tests/docs (Azure#22480) Increment version for eventhub releases (Azure#22485) [Cosmos] Remove support for Python27, set Python36 as minimum, and update cosmos emulator pipeline (Azure#22475) Increment version for servicebus releases (Azure#22484) add back py3.6 (Azure#22477) [AutoRelease] t2-datafactory-2022-01-06-31864 (Azure#22362) [AutoRelease] t2-apimanagement-2022-01-06-51326 (Azure#22361) [AutoRelease] t2-netapp-2022-01-12-75881 (Azure#22467) ...
rakshith91
pushed a commit
to rakshith91/azure-sdk-for-python
that referenced
this pull request
Apr 10, 2022
…date cosmos emulator pipeline (Azure#22475) * removed six package and updated packaging/ documentation to reflect new standards * massive oops, will rotate keys * change 3.7 to 3.6 * pylint * addressed Anna's comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes care of updating Cosmos to remove Python27 support and upgrade the minimum version to 3.6 as per current guidelines: https://github.com/Azure/azure-sdk-for-python/blob/main/doc/dev/packaging.md.
It also takes care of updating the cosmos emulator pipeline step to go against 3.6.