Fix non-variant default name for tests-weekly #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benbp
requested review from
danieljurek,
mitchdenny and
weshaggard
as code owners
weshaggard
approved these changes
Feb 19, 2021
benbp
added
the
Central-EngSys
|
Now that we are using the 1ES pools, do we need to have the weekly variants of the pipelines? |
|
@mitchdenny it's worth a discussion. I'm not sure we want/need a nightly frequency on sovereign cloud/canary tests. Obviously it makes issues fester longer, but not sure a future 5x nightly load is worth the value it brings. Also, I think sovereign cloud tests will have some degree of flakiness due to the lower reliability of those clouds, so it may reduce people's confidence in signal from the nightly failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default non-variant suffix is
testswhen it should betests-weeklyin the pipeline generator weekly convention.