Hide the navigation nodes for unmodified nodes in diff #9015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenkuttappan
added
APIView
Central-EngSys
maririos
reviewed
Sep 19, 2024
| @@ -186,6 +186,9 @@ public void ConvertToTreeTokenModel() | |||
| List<ReviewToken> currentLineTokens = new List<ReviewToken>(); | |||
| foreach(var oldToken in Tokens) | |||
| { | |||
| //Don't include documentation in converted code file due to incorrect documentation formatting used in previous model. | |||
There was a problem hiding this comment.
how did you find out this discrepancy? are there any automated tests we can run to keep this tool up to date with the design (as it changes)?
There was a problem hiding this comment.
Also couldn't you convert the old documentation to new. Seem like that would be a straightforward mapping? Would be weird to just exclude documentation.
maririos
reviewed
Sep 19, 2024
| @@ -270,6 +273,13 @@ public void ConvertToTreeTokenModel() | |||
| reviewLine.parentLine = parent; | |||
| } | |||
|
|
|||
| //Handle specific cases for C++ line with 'public:' and '{' to mark related line | |||
There was a problem hiding this comment.
is there another way we can guarantee this is only for c++? my worry is that another parser might have something similar and we don't know about and they run this tool and get a behavior that is not accurate
| @@ -259,4 +263,18 @@ function shouldAppendIfRowIsHiddenAPI(row: CodePanelRowData) { | |||
| } else { | |||
| return true; | |||
| } | |||
| } | |||
|
|
|||
| function FilterVisibleNavigationNodes(node: NavigationTreeNode) { | |||
There was a problem hiding this comment.
Should you make this private?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hive the nodes if a corresponding code line is not visible in case of custom navigation tree. This PR also has the changes to exclude documentation when converting tokens from old model to streamline the token structure. Old token model has incorrect documentation line with partial code line.