APIM: Delete subscriptions when deleting products #3467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ross-p-smith
requested review from
davefellows,
theunrepentantgeek,
matthchr,
babbageclunk and
super-harsh
as code owners
ross-p-smith
changed the title
theunrepentantgeek
requested changes
Oct 26, 2023
|
/ok-to-test sha=83b50e8 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Bevan Arps <bevan.arps@outlook.com>
Codecov Report
@@ Coverage Diff @@
## main #3467 +/- ##
==========================================
- Coverage 54.32% 54.31% -0.02%
==========================================
Files 1566 1567 +1
Lines 655434 655461 +27
==========================================
- Hits 356073 356015 -58
- Misses 241588 241641 +53
- Partials 57773 57805 +32
|
theunrepentantgeek
approved these changes
Oct 27, 2023
|
/ok-to-test sha=f8daa8b |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes two APIM issues
Goal Seeker behaviour
My previous work on APIM left a setting of
Recover: truewhen creating the apim instance. This will cause an error if you were to delete the recording and not have an apim instance in a deleted state.It would be better not to have this setting defined and allow it to error if there was a deleted APIM in your resource group - which is a smaller probability!
This would eventually be handled by having a goal seeking APIM creation #3433.
Test deletion of products
When we create an APIM Product, it creates a Subscription for that Product. This causes problems when you delete the Product; however there is a flag to pass deleteSubscriptions to true which will fix this. Override the default delete behaviour and use the go sdk to carry out the deletion. This will close #3408
How does this PR make you feel:
If applicable: