Allow newer versions of Go than we require in dev.sh #3681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should be safe given Go's compatability guarantees and it makes using ASO easier with dev.sh and other Go projects which may have moved to a newer Go version before we did easier.
matthchr
requested review from
davefellows,
theunrepentantgeek,
babbageclunk and
super-harsh
as code owners
super-harsh
approved these changes
Jan 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3681 +/- ##
==========================================
+ Coverage 53.48% 53.50% +0.02%
==========================================
Files 1356 1356
Lines 460157 460157
==========================================
+ Hits 246098 246218 +120
+ Misses 177135 177014 -121
- Partials 36924 36925 +1 ☔ View full report in Codecov by Sentry. |
|
/ok-to-test sha=5f79174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should be safe given Go's compatibility guarantees and it makes using ASO easier with dev.sh and other Go projects which may have moved to a newer Go version before we did easier.
If applicable: