Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the Language Version 2.0 Triggers #14866

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stephaniezyen
Copy link
Contributor

@stephaniezyen stephaniezyen commented Aug 20, 2024

Added an article on triggers for Language Version 2.0 to have it documented in our repo, in case anyone wants to avoid triggering the new language version.

Microsoft Reviewers: Open in CodeFlow

Copy link
Contributor

Test this change out locally with the following install scripts (Action run 10478271557)

VSCode
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-vsix.sh) --run-id 10478271557
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-vsix.ps1) } -RunId 10478271557"
Azure CLI
  • Mac/Linux
    bash <(curl -Ls https://aka.ms/bicep/nightly-cli.sh) --run-id 10478271557
  • Windows
    iex "& { $(irm https://aka.ms/bicep/nightly-cli.ps1) } -RunId 10478271557"

Copy link
Contributor

Dotnet Test Results

    71 files   -     36      71 suites   - 36   23m 32s ⏱️ - 7m 26s
11 043 tests  -     20  11 043 ✅  -     20  0 💤 ±0  0 ❌ ±0 
25 862 runs   - 12 927  25 862 ✅  - 12 927  0 💤 ±0  0 ❌ ±0 

Results for commit 2362cca. ± Comparison against base commit e42fbe6.

@@ -0,0 +1,11 @@
# Language Version 2.0 Triggers
Copy link
Member

@anthony-c-martin anthony-c-martin Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this go in MSDocs instead of on GitHub?

@@ -0,0 +1,11 @@
# Language Version 2.0 Triggers

We have recently developed a new Language Version 2.0, which provides a new format for resource definitions when transpiling to an ARM Template.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


We have recently developed a new Language Version 2.0, which provides a new format for resource definitions when transpiling to an ARM Template.

However, with this new language version, we noticed that it may cause breaking changes in some use cases.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a customer, this sentence wouldn't give me a lot of confidence in our engineering quality bar. "may cause breaking changes" doesn't give me any ability to evaluate risk when deciding to adopt the feature, and sounds like something I'd need to be very concerned about.

Could we make this more precise (e.g. "we are aware of the following behavioral differences", followed by a list with links to issues)?

Comment on lines +7 to +11
To avoid triggering Language Version 2.0, we recommend avoiding the following:
* Using user-defined types
* Using user-defined functions
* Using compile-time imports
* Using experimental features
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels unnecessarily negative. Could we invert it?

"Using any of following features will automatically enable language version 2.0 code generation:"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants