Changes to support renaming of model and properties based on API review #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krishna1s
approved these changes
Dec 7, 2023
radhikajain99
approved these changes
Dec 11, 2023
Himanshu49
added a commit
to Himanshu49/load-testing
that referenced
this pull request
Dec 14, 2023
…ew (Azure#75) * Changes in testType and AutoStop based on API review * Support kind in yaml file * Changes to support testType in yaml * Pushing js files --------- Co-authored-by: Himanshu Bisht <hbisht@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Renaming models and their properties in Portal on based on suggestion received on TypeSpec PR.
Changes
Added support for new properties along with old properties
testType -> kind
autoStopEnabled -> autoStopDisabled
errorRateTimeWindow -> errorRateTimeWindowInSeconds