Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean.sh should clean up the resources on disk that deploy.sh creates #192

Closed
glennmusa opened this issue May 5, 2021 · 0 comments · Fixed by #199
Closed

clean.sh should clean up the resources on disk that deploy.sh creates #192

glennmusa opened this issue May 5, 2021 · 0 comments · Fixed by #199
Assignees
@jjansen23
Labels
core New feature or request

Comments

@glennmusa
Copy link
Contributor

glennmusa commented May 5, 2021 •
edited
Loading

Benefit/Result/Outcome
When we finish a deployment, we clean up the deployed resources, but not the artifacts in the repository.

Description
We should delete the generated configuration, the generated .tfvars, and the generated .tfvars that reside in each src/core/* that are created by deploy.sh

Acceptance Criteria

  • Delete generated mlz.config and .tfvars
@glennmusa glennmusa added the core New feature or request label May 5, 2021
@glennmusa glennmusa changed the title clean.sh should clean up the terraform resources deploy.sh creates clean.sh should clean up the resources on disk that deploy.sh creates May 5, 2021
@jjansen23 jjansen23 self-assigned this May 7, 2021
jjansen23 pushed a commit that referenced this issue May 7, 2021
cleanup files created by deploy.sh #192
1c5a3eb
@jjansen23 jjansen23 mentioned this issue May 7, 2021
Merged
3 tasks
jjansen23 added a commit that referenced this issue May 11, 2021
@jjansen23 @glennmusa
cleanup files created by deploy.sh #192 (#199)
94e0a74 
* cleanup files created by deploy.sh #192

* removing all components .tfvars files

* used explicit tiers instead of '*'

* added function to delete files in dir by name

* changed order file deletes

* Update src/clean.sh

Adding the word INFO for consistency.

Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com>

Co-authored-by: jjansen23 <jerome@DESKTOP-IMETN7E.localdomain>
Co-authored-by: Glenn Musa <4622125+glennmusa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jjansen23 jjansen23

Labels
core New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

cleanup files created by deploy.sh #192 Azure/missionlz
2 participants
@glennmusa @jjansen23