Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Firewall Option for SKU #794

Closed
mikedzikowski opened this issue Jan 11, 2024 · 1 comment · Fixed by #839
Closed

Add Firewall Option for SKU #794

mikedzikowski opened this issue Jan 11, 2024 · 1 comment · Fixed by #839
Assignees
Labels
bicep Related to Bicep code

Comments

@mikedzikowski
Copy link
Contributor

mikedzikowski commented Jan 11, 2024

Benefit/Result/Outcome

Add a UI step/element to allow for selecting the Azure Firewall SKU type during a portal driven deployment.

Description

Remove default parameter and add an option in the UI for MLZ for the Azure Firewall SKU selection.

Acceptance Criteria

  • Allows users to select firewall SKU for their requirements.
@jamasten
Copy link
Contributor

jamasten commented Jan 23, 2024

Premium SKU is not available across all our clouds and is hardcoded in the solution. This issue needs higher prioritization.

@jamasten jamasten added the bicep Related to Bicep code label Jan 23, 2024
jamasten pushed a commit that referenced this issue Feb 6, 2024
* update firewall sku tier options to allow for standard and basic

* update allowed values

* build json

* build json and update readme

* set dnssettings as conditional based on SKU

* add dns settings for Standard tier condition

* update dns optoins based on SKU type

* update test values

* test values

* test dns values

* update

* test updates

* test updates with conditionals

* build json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bicep Related to Bicep code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants