Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mlz.portal.json #1058

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Update mlz.portal.json #1058

merged 1 commit into from
Jul 7, 2024

Conversation

hansdoerr
Copy link
Contributor

@hansdoerr hansdoerr commented Jul 6, 2024

Description

Updated "azureGateSubnetAddressPrefix" in bicep/form/mlz.portal.json to say "azureGatewaySubnetAddressPrefix". This enables users to deploy the template spec with other than default Gateway subnet settings, because it will error out otherwise, since the deployment will use the mlz.json setting for the Gateway Subnet and the mlz.portal.json entry won't match.

Issue reference

The issue this PR will close: #1057

Checklist

Please make sure you've completed the relevant tasks for this PR out of the following list:

  • All acceptance criteria in the backlog item are met
  • The documentation is updated to cover any new or changed features
  • Manual tests have passed
  • Relevant issues are linked to this PR

Updated "azureGateSubnetAddressPrefix" in bicep/form/mlz.portal.json to say "azureGatewaySubnetAddressPrefix".  This enables users to deploy the template spec with other than default Gateway subnet settings, because it will error out otherwise, since the deployment will use the mlz.json setting for the Gateway Subnet and the mlz.portal.json entry won't match.
@hansdoerr hansdoerr requested a review from a team as a code owner July 6, 2024 17:52
@jamasten
Copy link
Contributor

jamasten commented Jul 7, 2024

Thank you for your contribution @hansdoerr!

@jamasten jamasten merged commit fea49c2 into Azure:main Jul 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typo in "AzureGatewaySubnetPrefix" in /bicep/form/mlz.portal.json
2 participants