Add-On Imaging: Improvements, Bug Fixes, and Software Bundler #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added minorVersion to all templates to ensure version is Major.Minor.Patch
Made virtualMachineSize a variable rather than statically set
Made the custom software conditional based on a variable of enabled being set to true
Fixed incorrect variable name for Excel
Removed a sub folder called "Files" which is not needed
Added /i to msiexec installer which should always be present
Made second reboot dependent on installUpdates being set to true, otherwise it reboots twice for no reason
Changed softdelete on KV to true, otherwise deployment fails
Updated MI type on managementVM to User and System MI. System MIs are required for Hybrid Runbook workers.
Fixed bug in Tier 3 outputs
Added Bundler Software PowerShell script and manifest json file. The purpose of this is to get around the runCommand limit of 25 runCommands per resource.
Issue reference
The issue this PR will close: #[issue number]
Checklist
Please make sure you've completed the relevant tasks for this PR out of the following list: