Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inbound connection from hub to network tiers. #142

Merged
merged 3 commits into from
Apr 1, 2021

Conversation

Breanna-Stryker
Copy link
Contributor

Description

Renamed virtual network outbound peering, added secondary block to all tiers to peer tiers to the saca hub, using the designated azurerm.hub provider.

Issue reference

The issue this PR will close: #115

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Since the PR title is what makes it into the log, let's rename it as something more descriptive like 'add two-way peering between tiers and hub networks'.

@Breanna-Stryker Breanna-Stryker changed the title Bstryker/115saca vnet peering Add inbound connection from hub to network tiers. Apr 1, 2021
@Breanna-Stryker Breanna-Stryker merged commit 10501eb into main Apr 1, 2021
@Breanna-Stryker Breanna-Stryker deleted the bstryker/115saca_vnet_peering branch April 1, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add network peering from SACA hub to all tiers
2 participants