Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set firewall SKU to Premium where azurerm environments support it #148

Merged
merged 1 commit into from
Apr 9, 2021
Merged

set firewall SKU to Premium where azurerm environments support it #148

merged 1 commit into from
Apr 9, 2021

Conversation

glennmusa
Copy link
Contributor

@glennmusa glennmusa commented Apr 8, 2021 •
edited
Loading

Description

Toggle "Premium" or "Standard" Azure Firewall SKU given the Terraform azurerm environment setting.

Issue reference

The issue this PR will close: #111, #101

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

@glennmusa glennmusa requested a review from sstjean April 8, 2021 19:55
brooke-hamilton
brooke-hamilton approved these changes Apr 9, 2021
View reviewed changes
Copy link
Contributor

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deployed this to azure commercial and us gov with no issues.

@glennmusa glennmusa merged commit 4866c9b into main Apr 9, 2021
@glennmusa glennmusa deleted the glennmusa/firewallsku branch April 9, 2021 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brooke-hamilton brooke-hamilton brooke-hamilton approved these changes

@sstjean sstjean Awaiting requested review from sstjean

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Apply_tf.sh fails in Azure Gov because Azure Firewall Premium not supported
2 participants
@glennmusa @brooke-hamilton