Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Docker push commands and add checks for App properties #149

Merged
merged 3 commits into from
Apr 13, 2021

Conversation

Phydeauxman
Copy link
Contributor

@Phydeauxman Phydeauxman commented Apr 12, 2021

Description

Updated the commands used to push Docker image to use dynamic endpoints.
Added login to wait for the App creation process to propagate all properties before proceeding

Issue reference

The issue this PR will close: #144

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

Copy link
Contributor

@glennmusa glennmusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We still have work to do to pass along the Key Vault DNS suffix and the ARM metadatahost endpoint URL from the results of az cloud show but let's do that in another change. LGTM 👍

@Phydeauxman Phydeauxman merged commit 86022b2 into main Apr 13, 2021
@Phydeauxman Phydeauxman deleted the byboudre/dynamic_endpoints branch April 13, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup_ezdeploy fails when trying to deploy into Azure Government
2 participants