Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable the UI in other clouds #152

Merged
merged 5 commits into from
Apr 15, 2021
Merged

Conversation

glennmusa
Copy link
Contributor

@glennmusa glennmusa commented Apr 13, 2021

Description

This change makes it so that the UI will launch and successfully 'Execute Terraform' in a cloud other than AzureCloud by sourcing the Key Vault DNS suffix, the ARM Metadata Service Endpoint, the AAD login endpoint, and the Cloud Name from config.

To test this in say AzureUsGovernment try:

az cloud set -n AzureUsGovernment
az login
src/scripts/setup_ezdeploy.sh -s {your_subscription_id} -l usgovvirginia -e usgovernment

Issue reference

The issue this PR will close: #144, #151

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

@glennmusa glennmusa changed the title source UI cloud settings from configuration enable the UI in other clouds Apr 14, 2021
@glennmusa glennmusa enabled auto-merge (squash) April 14, 2021 13:13
Copy link
Contributor

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deployed this to US Gov and Azure commercial.

@glennmusa glennmusa merged commit 8ecab1b into main Apr 15, 2021
@glennmusa glennmusa deleted the glennmusa/cloudspecificuisettings branch April 15, 2021 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setup_ezdeploy fails when trying to deploy into Azure Government
2 participants