wait for app property queries by list to return results in UI app registration creation #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennmusa
changed the title
brooke-hamilton
approved these changes
Apr 15, 2021
glennmusa
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There's transient issues when
setup_ezdeploy.shattempts to source the App Registration password to store in KeyVault in AzureUsGovernment. This change adds a "wait for an app registration property query to return a result" function that hopes to prevent the query for app registration by ID fromaz ad app credential reseton L110 from failing.The underlying AZ CLI implementation queries for service principal by name:
https://github.com/Azure/azure-cli/blob/a4582a388033dde268fad640656acfe1a5781a64/src/azure-cli/azure/cli/command_modules/role/custom.py#L1703
Issue reference
The issue this PR will close: #144
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
shellcheck.vscode/extensions.json.)