add config_clean.sh as a way to clean up MLZ resources #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glennmusa
requested review from
Phydeauxman,
brooke-hamilton and
Breanna-Stryker
brooke-hamilton
approved these changes
Apr 16, 2021
brooke-hamilton
suggested changes
Apr 16, 2021
There was a problem hiding this comment.
My mistake, it looks like the cleanup script is deleting all the resources, including the hub and T0. That is not the intended behavior, right?
INFO: deleting rg-mlz-tf-mlz1618577267...
INFO: deleting rg-tf-sacahub-mlz1618577267...
INFO: deleting rg-tf-tier0-mlz1618577267...
INFO: deleting rg-tf-tier1-mlz1618577267...
INFO: deleting rg-tf-tier2-mlz1618577267...
INFO: deleting rg-saca-mlz1618577267...
INFO: deleting rg-t0-mlz1618577267...
INFO: deleting rg-t1-mlz1618577267...
INFO: deleting rg-t2-mlz1618577267...
INFO: deleting service principal sp-mlz-tf-mlz1618577267...
Removing role assignments
INFO: purging key vault mlzkvmlz1618577267d8f20d...
INFO: Complete! Resources for mlz1618577267 deleted!
|
@brooke-hamilton you're right, let me update how MLZ Configuration resources are tagged. |
This should be fixed @brooke-hamilton |
|
When I deployed everything to the same sub, this worked exactly as described. This scenario did not work:
src/deploy.sh -s {my_mlz_configuration_subscription_id} \
-h {my_hub_network_subscription_id} \
-0 {my_identity_network_subscription_id} \
-1 {my_operations_network_subscription_id} \
-2 {my_shared_services_network_subscription_id} \
-z {my_mlz_environment_name}
src/scripts/config/config_clean.sh src/generated-configurations/jbh002.mlzconfig
INFO: deleting mlz-config-jbh002...
Resource group 'mlz-config-jbh002' could not be found. |
That makes sense. I'll update to use the correct subscription. Thanks! |
glennmusa
commented
Apr 16, 2021
brooke-hamilton
approved these changes
Apr 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide a mechanism to clean up all the resources created by Mission LZ to support a deployment.
Issue reference
The issue this PR will close: #4, #150
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list:
shellcheck.vscode/extensions.json.)