Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .dockerignore to ignore terraform deployment artifacts #193

Merged
merged 3 commits into from
May 6, 2021

Conversation

glennmusa
Copy link
Contributor

Description

A user could run into an issue where they've deployed with one version (e.g. 2.50) of Terraform, thus generating a .terraform.lock.hcl file, while the source references another (e.g. 2.55).

This change ignores any of the terraform directories when building images from /src/ and removes a previously used argument that is no longer necessary from main.py.

Issue reference

The issue this PR will close: #191

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

Copy link
Contributor

@jjansen23 jjansen23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good and will resolve the issue of terraform version discrepancies as stated in the issue,

@glennmusa glennmusa merged commit 8a01855 into main May 6, 2021
@glennmusa glennmusa deleted the glennmusa/dockerignore branch May 6, 2021 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI deployments fail
2 participants