Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a Bastion Host module #209

Merged
merged 3 commits into from
May 18, 2021
Merged

add a Bastion Host module #209

merged 3 commits into from
May 18, 2021

Conversation

glennmusa
Copy link
Contributor

Description

Adds an Azure Bastion Host module that can be added to any virtual network given a valid subnet larger than /27.

To know this is working deploy an instance of MLZ and inspect the SACA Hub resource group. With the supplied defaults you should see a mlzDemoBastionHost resource and its accompanying public IP address mlzDemoBastionHostPip reside in a AzureBastionSubnet of 10.0.100.128/27.

Issue reference

The issue this PR will close: #186

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

@glennmusa glennmusa requested a review from jjansen23 May 18, 2021 11:06
@glennmusa glennmusa merged commit 4ab60f4 into main May 18, 2021
Copy link
Contributor

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to deploy the bastion host module in a single subscription. All resources were created successfully. No errors.

@glennmusa glennmusa deleted the glennmusa/bastion branch May 18, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

An Azure Bastion module that can be added to a virtual network
2 participants