Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add --no-bastion to allow users to opt-out of Bastion host and Jumpbox creation #217

Merged
merged 16 commits into from
May 20, 2021

Conversation

glennmusa
Copy link
Contributor

@glennmusa glennmusa commented May 20, 2021

Description

This change proposes a --no-bastion flag to CLI deployments that allow a user to opt-out of deploying an Azure Bastion Host and Windows virtual machine jumpbox into the Hub network.

To try this out, add the --no-bastion flag to a deployment like:

src/scripts/deploy.sh -s {my_sub_id} --no-bastion

There is one known issue: as of this PR, users are not able to opt out of Bastion Host and Jumpbox deployments from the UI. This limitation is tracked here: #213 -- this was fixed with #218

Issue reference

The issue this PR will close: #189

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

Copy link
Contributor

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I deployed with and without Bastion. 👍

@glennmusa glennmusa merged commit ba0c1db into main May 20, 2021
@glennmusa glennmusa deleted the glennmusa/nobastion branch May 20, 2021 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a way to optionally deploy Bastion host and jumpboxes in the Hub network
2 participants