Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable traffic analytics and bump network flow logs to v2 #248

Merged
merged 3 commits into from
Jun 10, 2021
Merged

enable traffic analytics and bump network flow logs to v2 #248

merged 3 commits into from
Jun 10, 2021

Conversation

glennmusa
Copy link
Contributor

@glennmusa glennmusa commented Jun 9, 2021 •
edited
Loading

Description

Adds traffic analytics to all subnets created by MLZ and updates all Flow Log resources to v2 for increased reporting abilities.

Issue reference

The issue this PR closes #203 and closes #196

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles or validates correctly
  • BASH scripts have been validated using shellcheck
  • All tests pass (manual and automated)
  • The documentation is updated to cover any new or changed features
  • Markdown files have been linted using the recommended linter. (See .vscode/extensions.json.)
  • Relevant issues are linked to this PR

@glennmusa glennmusa enabled auto-merge (squash) June 9, 2021 18:31
brooke-hamilton
brooke-hamilton approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@brooke-hamilton brooke-hamilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything deployed successfully and V2 is now enabled.

@glennmusa glennmusa merged commit af8b9e5 into main Jun 10, 2021
@glennmusa glennmusa deleted the glennmusa/networkflowlogsv2 branch June 10, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brooke-hamilton brooke-hamilton brooke-hamilton approved these changes

@Phydeauxman Phydeauxman Awaiting requested review from Phydeauxman

@Breanna-Stryker Breanna-Stryker Awaiting requested review from Breanna-Stryker

@jjansen23 jjansen23 Awaiting requested review from jjansen23

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enable Network Watcher Flow Logs V2 Enable Traffic Analytics and V2 Logs for NSG Flow Log Capture
2 participants
@glennmusa @brooke-hamilton